Skip to content

Conversation

@mglotov
Copy link
Contributor

@mglotov mglotov commented Apr 6, 2022

PR Description

  • Updated eks terraform module to the latest possible version (the version without any political slogans).
  • Changed a way of updating/patching aws-auth configmap. Terraform module documentation uses local-exec, but this approach isn't very useful. I've decided to use kubectl provider to update aws-auth configmap and to get rid of running locac-exec.

Fixes #244

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov force-pushed the enh/update-eks-module branch from cc3501f to cdb4a99 Compare April 6, 2022 12:07
@mglotov mglotov force-pushed the enh/update-eks-module branch from cdb4a99 to 98c0d93 Compare April 7, 2022 04:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov requested review from a team, halfb00t, khalezin and p1gmale0n April 7, 2022 04:51
@mglotov mglotov merged commit b49fd5e into main Apr 7, 2022
@mglotov mglotov deleted the enh/update-eks-module branch April 7, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enh: Upgrade AWS EKS module version to the latest 18.2.0

4 participants