Skip to content

fixed deprecated issues with bucket encryption, lifecylce, bucket_acl and key algorithm #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2022
Merged

fixed deprecated issues with bucket encryption, lifecylce, bucket_acl and key algorithm #303

merged 3 commits into from
Aug 16, 2022

Conversation

@sviatoslav6
Copy link
Contributor

@sviatoslav6 sviatoslav6 commented Aug 12, 2022 •
edited by halfb00t
Loading

PR Description

I have corrected the deprecated resources with bucket encryption, lifecylce, bucket_acl and key algorithm

Fixes #300

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@sviatoslav6 sviatoslav6 self-assigned this Aug 12, 2022
@sviatoslav6 sviatoslav6 linked an issue Aug 12, 2022 that may be closed by this pull request
fix: Convert encryption to aws_s3_bucket_server_side_encryption_configuration resource for all buckets #300
Closed
3 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sviatoslav6 sviatoslav6 merged commit 917000c into main Aug 16, 2022
@sviatoslav6 sviatoslav6 deleted the fix/s3_bucket branch August 16, 2022 05:56
p1gmale0n pushed a commit that referenced this pull request Aug 24, 2023
@sviatoslav6 @p1gmale0n
fix: fixed deprecated issues with bucket encryption, lifecylce, bucke…
1f1d149 
…t_acl and key algorithm (#303)

* fix: fixed deprecated issues with bucket encryption, lifecylce, bucket_acl and key algorithm

* fix: fixed deprecated issues with bucket encryption, lifecylce, bucket_acl and key algorithm

* update terraform docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halfb00t halfb00t halfb00t approved these changes

@mglotov mglotov Awaiting requested review from mglotov

+1 more reviewer

@p1gmale0n p1gmale0n p1gmale0n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sviatoslav6 sviatoslav6

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: Convert encryption to aws_s3_bucket_server_side_encryption_configuration resource for all buckets

4 participants

@sviatoslav6 @p1gmale0n @halfb00t