Skip to content

fix: issue #304 layer2-aws terraform plan error #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 5, 2022
Merged

fix: issue #304 layer2-aws terraform plan error #305

merged 4 commits into from
Oct 5, 2022

Conversation

@sviatoslav6
Copy link
Contributor

@sviatoslav6 sviatoslav6 commented Oct 3, 2022 •
edited
Loading

PR Description

I added the line to the file eks-gitlab-runner.tf, to fix an error for terraform plan in layer2-aws

  count = local.gitlab_runner.enabled ? 1 : 0

Fixes #304

Type of change

  • [ X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov requested a review from a team October 5, 2022 07:40
@sviatoslav6 sviatoslav6 merged commit cf0cc18 into main Oct 5, 2022
@sviatoslav6 sviatoslav6 deleted the feature/304-terraform-plan-error branch October 5, 2022 11:56
p1gmale0n pushed a commit that referenced this pull request Aug 24, 2023
@sviatoslav6 @p1gmale0n
fix: issue #304 layer2-aws terraform plan error (#305)
21e4076 
* fix: issue #304 layer2-aws terraform plan error

* issue #305 fix tfsec

* issue #305 fix tfsec

* issue #305 fix tfsec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin khalezin approved these changes

@mglotov mglotov Awaiting requested review from mglotov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: terraform plan layer2-aws error

4 participants

@sviatoslav6 @halfb00t @khalezin