Skip to content

Conversation

@rhoerr
Copy link
Contributor

@rhoerr rhoerr commented Oct 9, 2025

magento2-base-2.0.0-beta1.zip didn't build during a preview release. This fixes that.

Issue was caused by changes from composerJsonPath -> composerJsonFile for mirroring during the refactoring

Two code bugs involved and fixed:

  • package.composerJsonFile would survive from history building to new release build (only if run without --skipHistory), causing it to rebuild a previous version for the new release
  • package.composerJsonFile would not be set to the value of composerJsonPath for new releases, causing it to not apply the template (came out magento2ce instead, the package name of the root ./composer.json in Magento core)

@rhoerr rhoerr requested a review from a team as a code owner October 9, 2025 03:01
@rhoerr rhoerr merged commit 59438d7 into mage-os:release/mage-os-2.0 Oct 9, 2025
1 check passed
@rhoerr rhoerr deleted the fix/base-build-error branch October 9, 2025 03:02
rhoerr added a commit that referenced this pull request Oct 16, 2025
* Bundle aligent/magento2-pci-4-compatibility (#239)

* Bundle mage-os/module-meta-robots-tag (#244)

* Bundle mage-os/meta-robots-tag

* Fixed composer package name based on latest changes

* Bundle mage-os/module-inventory-reservations-grid (#241)

* Bundle mage-os/module-pagebuilder-template-import-export (#230)

* Update dependencies-template.json with pagebuilder enhancements

* Add mage-os pagebuilder import/export and cms widget component modules to dependencies-template.json

* Update dependencies-template.json

* Fix wrong dependency git repos using https

* Changed PR to just mage-os/module-pagebuilder-template-import-export

---------

Co-authored-by: Ryan Hoerr <rhoerr@users.noreply.github.com>

* Bundle mage-os/module-page-builder-widget (#243)

* Fix magento2-base build error for new releases (#247)

* Bundle mage-os/module-theme-optimization (#242)

* Bundle mage-os/module-automatic-translation (#231)

* Add SEO meta robots module "mage-os/meta-robots-tag"

* Add automatica translation with AI module

* Changed PR to just mage-os/module-automatic-translation

---------

Co-authored-by: Ryan Hoerr <rhoerr@users.noreply.github.com>

* Changed mage-os-lab references to mage-os

* Fix magento2-base composer map of tiny_mce_6 to hugerte (#258)

---------

Co-authored-by: dadolun95 <dadolun@gmail.com>
Co-authored-by: SamueleMartini <40766441+SamueleMartini@users.noreply.github.com>
Co-authored-by: Mage-OS <100189073+mage-os-ci@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant