fix(cache-magento): address set-output deprecation (#231)#326
Merged
rhoerr merged 1 commit intomage-os:mainfrom May 5, 2026
Merged
fix(cache-magento): address set-output deprecation (#231)#326rhoerr merged 1 commit intomage-os:mainfrom
set-output deprecation (#231)#326rhoerr merged 1 commit intomage-os:mainfrom
Conversation
marcelmtz
approved these changes
May 3, 2026
marcelmtz
left a comment
marcelmtz
left a comment
There was a problem hiding this comment.
All good, just a reminder for standardize it in the future.
| echo "dir=$(composer config cache-files-dir --global)" >> $GITHUB_OUTPUT | ||
|
|
||
| - run: echo "::set-output name=version::$(php -v | awk 'NR==1{print $2}')" | ||
| - run: echo "version=$(php -v | awk 'NR==1{print $2}')" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Looks like in the same file we have unquoted "$GITHUB_OUTPUT", not critical for this PR but I might introduce another change to standardize all to the above entry
Member
Author
There was a problem hiding this comment.
A linting rule here would be very helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Annoying set-output logs.
Fixes: N/A
What is the new behavior?
No more set-output logs.
Does this PR introduce a breaking change?
Other information