Skip to content

feat(coding-standard)!: simplify action architecture#342

Merged
rhoerr merged 1 commit intomage-os:mainfrom
damienwebdev:coding-standard-alignment
May 5, 2026
Merged

feat(coding-standard)!: simplify action architecture#342
rhoerr merged 1 commit intomage-os:mainfrom
damienwebdev:coding-standard-alignment

Conversation

@damienwebdev
Copy link
Copy Markdown
Member

PR description

Summary

  • Aligns coding-standard/action.yml with the graycore source of truth per #331
  • Removes embedded PHP setup and project checkout from the action — callers are now responsible for PHP/composer setup (matching graycore's lean architecture)
  • Adds composer_auth input, already-installed skip logic, vendor/mage-os path support, php-compatibility-fork, improved flags handling, and branding
  • Updates _internal-coding-standard.yaml to set up PHP in the workflow and use currently-supported matrix

Breaking changes

  • php_version and composer_version inputs removed — callers must add a shivammathur/setup-php step before invoking this action
  • path default changed from app/code to .

Remove embedded PHP setup and checkout from the action; PHP version and
composer version are now the caller's responsibility (set up via
shivammathur/setup-php before invoking this action).

Breaking changes:
- Remove `php_version` and `composer_version` inputs
- Change `path` default from `app/code` to `.`

New features ported from graycore:
- Add `composer_auth` input (passed as COMPOSER_AUTH env var)
- Skip install when coding standard is already present (check-installed)
- Support both vendor/magento and vendor/mage-os install paths
- Require magento/php-compatibility-fork alongside coding standard
- Improved phpcs flags via bash array; respects .phpcs.xml config files
- Add branding block (icon: code, color: green)

Remove changed-files detection (PR diff mode) — not present in graycore.
@damienwebdev damienwebdev requested a review from a team as a code owner May 2, 2026 17:10
@rhoerr rhoerr merged commit bc96953 into mage-os:main May 5, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants