Add the ability to manually select the active admin theme #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set Mage-OS as default in config.xml * Update plugin to use new config value
* Code cleanup
aleron75
approved these changes
May 15, 2025
pykettk
approved these changes
May 15, 2025
Vinai
approved these changes
May 16, 2025
rhoerr
reviewed
May 20, 2025
Co-authored-by: Ryan Hoerr <rhoerr@users.noreply.github.com>
rhoerr
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7 #8
See the issue for the rationale. Additional notes below.
This PR specifically aids us at Hyvä in regard to building our own admin theme for Hyvä Commerce using the M137 theme as a base, but we felt it may be useful for others, too, so we wanted to contribute back here. If it's not something you want included in this module, we're happy to implement this for our own needs internally instead.
I'm also aware that removing and replacing the existing configuration option with a new select-based option should be considered a major breaking change. However, as the new config option also defaults to the Mage-OS M137 Admin Theme, the only users who would be impacted are those who have already installed the theme but then disabled it, which I believe is likely to be very few people at this stage. Disabling it again is not difficult, nor does it affect business logic. At worst, it may be a minor annoyance. Open for further discussion or approaches that could mitigate this further.
I noticed a couple of small issues I've resolved in this PR (see #8), if you'd prefer these are moved in a separate PR, let me know.