Skip to content

improving fragment in post collection #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020
Merged

improving fragment in post collection #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions Model/ResourceModel/Post/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,14 @@ protected function _construct()
*/
public function addFieldToFilter($field, $condition = null)
{
/* NEED TO IMPROVE THIS CODE */
if (is_array($field) && count($field) > 1) {
return parent::addFieldToFilter($field, $condition);
}

if (is_array($field) && count($field) == 1) {
$field = $field[0];
if (isset($condition[0])) {
$condition = $condition[0];
if (is_array($field)) {
if (count($field) > 1) {
return parent::addFieldToFilter($field, $condition);
} elseif (count($field) === 1) {
$field = $field[0];
$condition = $condition[0] ?? $condition;
}
}
/* END NEED TO IMPROVE */

if ($field === 'store_id' || $field === 'store_ids') {
return $this->addStoreFilter($condition);
Expand Down Expand Up @@ -158,7 +154,7 @@ public function addStoreFilter($store, $withAdmin = true)
}
return $this;
}

/**
* Add "include in recent" filter to collection
* @return $this
Expand All @@ -167,7 +163,7 @@ public function addRecentFilter()
{
return $this->addFieldToFilter('include_in_recent', 1);
}

/**
* Add posts filter to collection
* @param array|int|string $category
Expand Down