Skip to content

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Oct 27, 2019

Description (*)

  • Enhance assertions. Using the assertTrue and assertFalse to assert expected is true or false.
  • Enhance AdobeIms tests.
  • To support future PHPUnit 8.x version, replacing expected exception annotations with expectExcpetion and expectExceptionMessage methods.
  • Removing unused Get class namespace declaring.
  • According to the PHPUnit fixture reference, the setUp method is protected with void type hint.
  • Add the php-7.1 and php-7.3 versions tests on Travis CI build.

Manual testing scenarios (*)

  • The Travis CI build will be passed successfully.

@sivaschenko sivaschenko merged commit 743549a into magento:develop Oct 29, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

Hi @peter279k, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@peter279k peter279k deleted the enhance_adobelms_tests branch October 29, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants