Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5115 Add ViewModels section to 2.2 dev-guide #5147

Merged
merged 10 commits into from Aug 26, 2019

Conversation

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 9, 2019

An admin must run tests on this PR before it can be merged.

@diazwatson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

Q. How can I add this new topic to the Component development section?

@osrecio osrecio self-assigned this Aug 9, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 9, 2019

@diazwatson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Hi guys, is there any update on this?

thanks

@diazwatson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Ups 🤦‍♂
Thanks @dobooth

@osrecio
Copy link
Member

left a comment

From technical part is cool for me! Good job @diazwatson ! 👍

@osrecio

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Now is valid for me. @dobooth what do you think?

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Hey @diazwatson & @osrecio, sorry for the delay on this. @dobooth is on holiday. I can help finish processing this for you.

@diazwatson, to add this to the navigation, add an entry to the devdocs/_data/toc/php-developer-guide.yml file.

In the meantime, I'll do an editorial review.

guides/v2.2/extension-dev-guide/view-models.md Outdated Show resolved Hide resolved
guides/v2.2/extension-dev-guide/view-models.md Outdated Show resolved Hide resolved
guides/v2.2/extension-dev-guide/view-models.md Outdated Show resolved Hide resolved
guides/v2.2/extension-dev-guide/view-models.md Outdated Show resolved Hide resolved
guides/v2.2/extension-dev-guide/view-models.md Outdated Show resolved Hide resolved
guides/v2.2/extension-dev-guide/view-models.md Outdated Show resolved Hide resolved
guides/v2.2/extension-dev-guide/view-models.md Outdated Show resolved Hide resolved
@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

@diazwatson, you need to add a symlink to the 2.2 file in the 2.3 directory for this to apply to both versions.

diazwatson added 3 commits Aug 24, 2019
Merge remote-tracking branch 'upstream/master' into 5115_viewModels
* upstream/master: (42 commits)
  Update Magento 2.3.0 Open Source release notes (#5267)
  changed "change" to "remove" per Anthony chico
  Small changes (#5264)
  changed column name to ital instead of code
  magento/devdocs#: Fix release notice info about STATIC_CONTENT_THREADS and change info on the appropriate pages (#5263)
  Updated instructions for reviewing cron configuration (#5239)
  Add GSC meta tag (#5258)
  updated code language
  Add GTM tag in order to verify site in GSC (#5254)
  Added note for 404 errors
  MAGEDOC-4061: Added Q3 Commerce releases (#5236)
  Change wording
  Removed legacy Cloud infrastructure info (#5125)
  Removed the unused files
  Fix style violations
  Updated What's New for documentation updates since Aug 9, 2019 (#5212)
  Update debug.md (#5134)
  Link to new marketing PDF from release info page (#5223)
  Debug logging options should match sentence context (#5219)
  Remove spaces inside link text
  ...
@diazwatson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

@jeff-matthews thanks for taking the time to process this.
The requested changes are now done, please review and let me know if there is any.

Thanks

@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Request Progress Aug 24, 2019

@diazwatson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

@keharper requested changes are added.

@jeff-matthews
Copy link
Contributor

left a comment

Thanks @diazwatson!

@jeff-matthews jeff-matthews moved this from Review in Progress to Acceptance Testing in Pull Request Progress Aug 26, 2019

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

running tests

@jeff-matthews jeff-matthews merged commit 2afa6b4 into magento:master Aug 26, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 26, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Acceptance Testing to Done in Pull Request Progress Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.