-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Remove abandoned Baler module #7876
Conversation
|
An admin must run tests on this PR before it can be merged. |
bdenham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check!
|
running tests |
|
Hi @Leland, thank you for your contribution! |
|
Fastest Magento merge ever. Thanks y'all 💌 |
|
It might be good to remove the 'baler' references in the Lighthouse stack-pack that was added for Magento: https://github.com/GoogleChrome/lighthouse/pull/9797/files#diff-308b7b792d1ff34f5f1059de97567b43R1535-R1540 I'm thinking a link to the page on Advanced JS Bundling, MagePack, or perhaps just a link to the former (with an update to link to MagePack as a simpler means of going about achieving the bundling?) What do you all think? |
|
@davidalger That makes sense to me, but maybe better to ask the question in that repo. Adding @DrewML for his technical expertise. |
|
Magepack is a great alternative for those looking. |
|
@davidalger added an issue to the Lighthouse repo regarding that, if you want to add any thoughts about a replacement 🍻 GoogleChrome/lighthouse#11954 Have not had a chance to use Magepack, personally. |
Purpose of this pull request
Magento's "early Alpha" bundling solution
balerhas not been under development since the release of Magento v2.3.4, 7 months ago – I propose it be removed from the "Advanced JavaScript bundling" page masthead.baler, in general, does not appear to have been tested whatsoever on modern Magento versionsI desperately hope development on
baleris resuscitated. It's a fabulous tool, and better bundling is needed on Magento. But recommending a stale, broken, unsupported, and undeveloped approach – even in an "alpha testing" way – does not seem wise!Magento's "Magento Tech Tips," a resource that provides performance advice for Commerce Cloud clients, links out to this page. Clients should not be seeing broken alpha software recommendations in the masthead. I've even had Commerce Cloud
support reps recommend I test out
balerto improve performance on clients. Another no-no.Also see my issue on the
balerrepo proper: magento/baler#70Affected DevDocs pages
Links to Magento source code