Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@Leland
Copy link
Contributor

@Leland Leland commented Sep 15, 2020

Purpose of this pull request

Magento's "early Alpha" bundling solution baler has not been under development since the release of Magento v2.3.4, 7 months ago – I propose it be removed from the "Advanced JavaScript bundling" page masthead.

I desperately hope development on baler is resuscitated. It's a fabulous tool, and better bundling is needed on Magento. But recommending a stale, broken, unsupported, and undeveloped approach – even in an "alpha testing" way – does not seem wise!

Magento's "Magento Tech Tips," a resource that provides performance advice for Commerce Cloud clients, links out to this page. Clients should not be seeing broken alpha software recommendations in the masthead. I've even had Commerce Cloud
support reps recommend I test out baler to improve performance on clients. Another no-no.

Also see my issue on the baler repo proper: magento/baler#70

Affected DevDocs pages

Links to Magento source code

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@meker12 meker12 requested review from YPyltiai and removed request for YPyltiai September 15, 2020 03:08
Copy link
Contributor

@bdenham bdenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check!

@meker12
Copy link
Contributor

meker12 commented Sep 15, 2020

running tests

@meker12 meker12 merged commit 367e8bf into magento:master Sep 15, 2020
@ghost
Copy link

ghost commented Sep 15, 2020

Hi @Leland, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Leland Leland deleted the remove-baler branch September 15, 2020 21:13
@Leland
Copy link
Contributor Author

Leland commented Sep 15, 2020

Fastest Magento merge ever. Thanks y'all 💌

@davidalger
Copy link
Member

It might be good to remove the 'baler' references in the Lighthouse stack-pack that was added for Magento: https://github.com/GoogleChrome/lighthouse/pull/9797/files#diff-308b7b792d1ff34f5f1059de97567b43R1535-R1540

I'm thinking a link to the page on Advanced JS Bundling, MagePack, or perhaps just a link to the former (with an update to link to MagePack as a simpler means of going about achieving the bundling?)

What do you all think?

@meker12
Copy link
Contributor

meker12 commented Sep 21, 2020

@davidalger That makes sense to me, but maybe better to ask the question in that repo. Adding @DrewML for his technical expertise.

@davidwindell
Copy link

Magepack is a great alternative for those looking.

@Leland
Copy link
Contributor Author

Leland commented Jan 13, 2021

@davidalger added an issue to the Lighthouse repo regarding that, if you want to add any thoughts about a replacement 🍻 GoogleChrome/lighthouse#11954

Have not had a chance to use Magepack, personally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants