Skip to content

[CMS Team 2] MFTF Redundant Waits #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 22, 2018
Merged

[CMS Team 2] MFTF Redundant Waits #24

merged 10 commits into from
Mar 22, 2018

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented Mar 21, 2018 •
edited
Loading

Scope

Tasks

Bamboo CI Builds

Jenkins Builds

Checklist

  • PR is green on M2 Quality Portal
  • Jira issues have accurate summary, meaningful description and have links to relevant documentation at the story/task level
  • Pull Request approved by architect
  • Pull Request quality review performed by @tjwiebell
  • All unstable functional acceptance tests are isolated (if any)
  • All linked Zephyr tests are approved by PO and have Ready to Use status
  • Travis CI build is green (for mainline CE only)

dhaecker and others added 6 commits March 13, 2018 16:16
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
e40f86a 
- removing all explicit waits & replacing with smart waits
- adding test suite group to columns tests
- making some one off items use share code or do things more efficiently
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
ef408d0 
- Fixing navigate to Pagebuilder bug
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
f3fedc2 
- Addressing comments from review
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
5652cf5 
- Fixing failures from Jenkins run
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
8b447ce 
- Cleaning up more redundancy
- Fixing open edit panel to wait for the element that takes the longest to load
@tjwiebell
Merge remote-tracking branch 'mainline/develop' into MAGETWO-88402-Cl…
1dda8d6 
…eanup-Redundant-Waits
@dhaecker dhaecker force-pushed the MAGETWO-88402-Cleanup-Redundant-Waits branch from 7857965 to 1dda8d6 Compare March 21, 2018 22:49
dhaecker added 4 commits March 22, 2018 12:16
@dhaecker
Merge remote-tracking branch 'mainline/develop' into MAGETWO-88402-Cl…
5212de9 
…eanup-Redundant-Waits
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
6a5fdb4 
- Removing unused action groups that I was unsure of during resolving merge conflicts
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
9c3f043 
- Fixing test failures
@dhaecker
MAGETWO-88402: MFTF - Cleanup Redundant Waits
dc6398a 
- Adding in code to disablepagebuilder action group to handle scenarios where pagebuilder is not already enabled
@melnikovi melnikovi self-requested a review March 22, 2018 22:52
@melnikovi melnikovi merged commit 38a9d4b into magento:develop Mar 22, 2018
@tjwiebell tjwiebell deleted the MAGETWO-88402-Cleanup-Redundant-Waits branch April 10, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@melnikovi melnikovi melnikovi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjwiebell @melnikovi @dhaecker