Skip to content

[CMS Team 1] Sprint 6 - Tech Debts #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 2, 2018
Merged

[CMS Team 1] Sprint 6 - Tech Debts #41

merged 17 commits into from
May 2, 2018

Conversation

raith-hamzah
Copy link

@raith-hamzah raith-hamzah commented Apr 25, 2018 •
edited by anthoula
Loading

Scope

Task

  • MAGETWO-89414 Tech Debt: PageBuilder replace EventBus with uiEvents
  • MAGETWO-87067 Tech Debt: Revise visibility of public methods and properties
  • MAGETWO-90937 Cannot read property 'block' of undefined when viewing saved page containing tabs
  • MAGETWO-90935 Adding a tab does not make new tab active and focused
  • MAGETWO-90464 Stabilize Builds

Bamboo CI Builds

Jenkins

Checklist

  • PR is green on M2 Quality Portal
  • Jira issues have accurate summary, meaningful description and have links to relevant documentation at the story/task level
  • Semantic Version build failure is approved by architect (if build is red)
  • Pull Request approved by architect Igor Melnykov
  • Pull Request quality review performed by: @anthoula
  • All unstable functional acceptance tests are isolated (if any)
  • All linked Zephyr tests are approved by PO and have Ready to Use status
  • Travis CI build is green (for mainline CE only)
  • Jenkins Extended FAT build is green

Cari Spruiell and others added 9 commits April 13, 2018 13:57
MAGETWO-87067: [Tech Debt] Revise visibility of public methods and pr…
fe6c4a2 
…operties

 - modify visibility where needed
@raith-hamzah
MAGETWO-89414: PageBuilder replace EventBus with uiEvents
77f9559 
- Refactored some classes to use uiEvents
@raith-hamzah
MAGETWO-89414: PageBuilder replace EventBus with uiEvents
d5514a7 
- Refactored more classes
@raith-hamzah
MAGETWO-89414: PageBuilder replace EventBus with uiEvents
b355694 
- Fixed parameters for events on functions
@raith-hamzah
MAGETWO-89414: PageBuilder replace EventBus with uiEvents
1ed5cd2 
- Fixed dependencies in knockout to use native magento events instead of the event bus
@raith-hamzah
MAGETWO-89414: PageBuilder replace EventBus with uiEvents
ae0364f 
- Fixed issue with multiple instances having similar event namespaces
- Refactored wysiwyg to new event system
@raith-hamzah
MAGETWO-89414: PageBuilder replace EventBus with uiEvents
77a5908 
- Removed unnecessary parameter
@raith-hamzah
Merge remote-tracking branch 'origin/MAGETWO-87067-Tech-Debt-Revise-v…
b6c9cb3 
…isibility-new' into cms-team-1-delivery-sprint-6
@anthoula
Merge remote-tracking branch 'mainline/develop' into cms-team-1-deliv…
0571852 
…ery-sprint-6

# Conflicts:
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/buttons.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/column-group.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/column.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/content-block.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/factory.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/block.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/column-group.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/map.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/newsletter.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/product-list.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/product.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/row.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/slider.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/tabs.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/slider.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/tabs.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/stage-builder.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/stage.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/stage/event-handling-delegate.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/stage/panel.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/stage/structural/abstract.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/stage/structural/editable-area.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/stage/structural/options/title.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/resource/sortable/knockout-sortable.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/buttons.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/column-group.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/column.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/factory.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/block.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/column-group.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/content-block.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/map.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/newsletter.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/product-list.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/product.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/row.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/slider.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/sortable/binding.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/tab-item.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/tabs.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/slider.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/tabs.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage-builder.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage/event-handling-delegate.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage/panel.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage/structural/abstract.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage/structural/editable-area.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage/structural/options/option.ts
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/stage/structural/options/title.ts
@anthoula anthoula changed the title [Cms team 1] Sprint 6 - Tech Debts [CMS Team 1] Sprint 6 - Tech Debts Apr 25, 2018
@anthoula anthoula added the next label Apr 25, 2018
@anthoula anthoula removed the next label Apr 26, 2018
@tjwiebell tjwiebell removed the next label May 1, 2018
@anthoula
Merge remote-tracking branch 'mainline/develop' into cms-team-1-deliv…
473b2e2 
…ery-sprint-6

# Conflicts:
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/component/block/preview/buttons.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/component/block/preview/buttons.ts
@anthoula
MAGETWO-90464: Stabilize Builds
5a944e6 
- fix merge conflict
@anthoula anthoula merged commit d3b49e0 into magento:develop May 2, 2018
@cspruiell cspruiell deleted the cms-team-1-delivery-sprint-6 branch September 14, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raith-hamzah @tjwiebell @anthoula @cspruiell