Skip to content

Conversation

@fredden
Copy link
Member

@fredden fredden commented Jun 15, 2021

Description

This preference is defined in XML but the class referenced does not exist. The class does exist in the adminhtml area, so I've moved the preference there. This is blocking progress on magento/magento2#33161

Story

None

Bug

None

Task

None

Fixed Issues (if relevant)

None

Builds

Unknown

Related Pull Requests

magento/magento2#33161

Do not add the magic comment that links pull requests together. These are related pull requests, not part of the same work.

Manual testing scenarios

No visible changes should be apparent with this change.

Questions or comments

None

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

6 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Hotel engcom-Hotel self-requested a review December 20, 2023 08:02
@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel
Copy link
Collaborator

Moving this PR On Hold as we are not able to run the tests on this PR. Currently, there is a ongoing JIRA to resolve this issue:

https://jira.corp.adobe.com/browse/ACPLTSRV-4253

@fredden
Copy link
Member Author

fredden commented Feb 19, 2024

@magento run all tests

as requested via Slack by @engcom-Hotel.

@engcom-Hotel
Copy link
Collaborator

As we are unable to run the automated tests on this PR, we have created a new PR to preserve the commits of this PR:

https://github.com/magento-commerce/magento2-page-builder/pull/304

Hence closing this PR.

@hostep
Copy link
Contributor

hostep commented Jul 23, 2024

Looks like it got merged after all (finally): 6dd003e...bdc2e1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants