-
Notifications
You must be signed in to change notification settings - Fork 73
Fix item name font_size_formats #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix item name font_size_formats #888
Conversation
|
@magento run all tests |
engcom-Hotel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MartinVanVan,
Thanks for the contribution!
The code changes seem good to us. But please add some automated test in accordance of DOD and also fix the failed static tests.
Thanks
|
@magento run Static Tests, Functional Tests EE, Functional Tests B2B |
|
@magento run Static Tests, Functional Tests B2B |
|
Hello @MartinVanVan, Have you got a chance to work on the failures of this PR? Thanks |
|
@engcom-Hotel I haven't got time to work on this. |
|
@engcom-Hotel Please fix your Static Tests and Functional Tests B2B |
|
@magento run all tests |
|
Hello @MartinVanVan, As per the mentioned in the manual testing scenario we need to apply patch It is recommended that someone needs to apply Thanks |

Description (*)
The item name that is defined in the adminhtml/di.xml for the
Magento\PageBuilder\Model\Wysiwyg\DefaultConfigProvideris wrong. The solution is to change the item name from fontsize_formats to font_size_formats.So the font size dropdown in the tinymce toolbar is showing the defined options.
Bug
Fixed Issues (if relevant)
Manual testing scenarios (*)
Checklist