Skip to content

Conversation

@MartinVanVan
Copy link

Description (*)

The item name that is defined in the adminhtml/di.xml for the Magento\PageBuilder\Model\Wysiwyg\DefaultConfigProvider is wrong. The solution is to change the item name from fontsize_formats to font_size_formats.
So the font size dropdown in the tinymce toolbar is showing the defined options.

Bug

Fixed Issues (if relevant)

  1. Wrong config key fontsize_formats in di.xml results in missing font size option in page builder #886: Wrong config key fontsize_formats in di.xml results in missing font size option in page builder

Manual testing scenarios (*)

  1. Apply patch ACSD-62755
  2. create or edit a page/block
  3. insert or select a text element
  4. toolbar should show all defined font size options in dropdown
image

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MartinVanVan,

Thanks for the contribution!

The code changes seem good to us. But please add some automated test in accordance of DOD and also fix the failed static tests.

Thanks

@MartinVanVan
Copy link
Author

@magento run Static Tests, Functional Tests EE, Functional Tests B2B

@MartinVanVan
Copy link
Author

@magento run Static Tests, Functional Tests B2B

@engcom-Hotel
Copy link
Collaborator

Hello @MartinVanVan,

Have you got a chance to work on the failures of this PR?

Thanks

@MartinVanVan
Copy link
Author

@engcom-Hotel I haven't got time to work on this.
I think these tests are bit silly as they failed as a false positive. The failure has nothing to do with my change.
Also I don't know how to add an automated test for change where i just change a config key.

@MartinVanVan
Copy link
Author

MartinVanVan commented Feb 24, 2025

@engcom-Hotel Please fix your Static Tests and Functional Tests B2B
Thanks

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

Hello @MartinVanVan,

As per the mentioned in the manual testing scenario we need to apply patch ACSD-62755 but this patch has been marked as deprecated. When we are trying to apply the above patch in 2.4.7-p3, the following information has been displayed:

image

It is recommended that someone needs to apply ACSD-62708 to resolve this issue. Hence I think we can close this PR, but we truly appreciate your contribution here.

Thanks

@engcom-Hotel engcom-Hotel removed the Project: Community Picked PRs upvoted by the community label Feb 26, 2025
@engcom-Hotel engcom-Hotel added the Project: Community Picked PRs upvoted by the community label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Project: Community Picked PRs upvoted by the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants