Skip to content

Inspection warning for disabling of an invalid plugin #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 10, 2020
Merged

Inspection warning for disabling of an invalid plugin #382

merged 6 commits into from
Nov 10, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 8, 2020 •
edited
Loading

Description

This PR adds

  • inspection warning for disabling of a plugin which doesn't exist in di.xml
  • test coverage

Fixed Issues

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne drpayyne changed the title Issue 147 Inspection warning for invalid plugin disabling Nov 8, 2020
@drpayyne drpayyne changed the title Inspection warning for invalid plugin disabling Inspection warning for disabling of an invalid plugin Nov 8, 2020
@coderimus coderimus self-assigned this Nov 10, 2020
@coderimus coderimus self-requested a review November 10, 2020 06:51
@drpayyne
Copy link
Contributor Author

@coderimus this looks like a one off error, can you please trigger the tests rerun?

@coderimus coderimus merged commit 71bbf42 into magento:2.1.0-develop Nov 10, 2020
@DmitryFurs DmitryFurs mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@coderimus coderimus coderimus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@coderimus coderimus

Labels
Award: test coverage Medium partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drpayyne @coderimus @magento-engcom-team