The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery

[novakivskiy]

Preconditions

1. Magento 2.1.9

Steps to reproduce

1. edit file <theme>/etc/view.xml
2. add <var name="allowfullscreen">false</var> to mobile breakpoints
   Example:

   <var name="breakpoints">
            <var name="mobile">
                <var name="conditions">
                    <var name="max-width">767px</var>
                </var>
                <var name="options">
                    <var name="options">
                        <var name="navigation">dots</var>
                        <var name="allowfullscreen">false</var>
                    </var>
                </var>
            </var>
        </var>

3. clean cache and open source html
4. find plugin "mage/gallery/gallery" init options on html page. The reason is in the type of the option "allowfullscreen" value, false as string, instead boolean.

"breakpoints": {"mobile":{"conditions":{"max-width":"767px"},"options":{"options":{"navigation":"dots","allowfullscreen":"false"}}}} }

Expected result

For screens smaller than <720px, do not open the gallery full screen

Actual result

1. Screen http://take.ms/CfOWC

[magento-engcom-team]

@novakivskiy, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. Please provide more detailed steps to reproduce.

[KirillLitvinenko]

Can reproduce on magento 2.2 by following steps.

Steps are the same:

1. in <theme>/etc/view.xml in <var name="breakpoints"> option <var name="allowfullscreen"> to false

Code after changes:

<var name="breakpoints">
    <var name="mobile">
        <var name="conditions">
            <var name="max-width">767px</var>
         </var>
         <var name="options">
             <var name="options">
                 <var name="nav">dots</var>
                 <var name="allowfullscreen">false</var>
             </var>
         </var>
    </var>
</var>

2. Clear cache

Expected result:

fullscrreen is disabled on mobile screens

Actual result:

fullscreen is working

Can be because of json that set to window object contains only string as value for breakpoints (example: "allowfullscreen": "false") object (should be bool for allowfullscreen key)

"breakpoints": {
  "mobile": {
    "conditions": {
      "max-width": "767px"
    }, 
    "options": {
      "options": {
        "nav": "dots", 
        "allowfullscreen": "false"
      }
    }
  }
}

[joebordo]

Just Posted the Same issue my self on magento 2.2.1.

[magento-engcom-team]

@novakivskiy, thank you for your report.
We've created internal ticket(s) MAGETWO-84793 to track progress on the issue.