Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated elements id in checkout page #13415

Closed
angelo983 opened this issue Jan 29, 2018 · 40 comments
Closed

Duplicated elements id in checkout page #13415

angelo983 opened this issue Jan 29, 2018 · 40 comments
Labels
Component: Checkout Component: GiftMessage Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs

Comments

@angelo983
Copy link
Member

angelo983 commented Jan 29, 2018 •
edited by ishakhsuvarov

Preconditions

  1. Magento 2.1.10

Steps to reproduce

  1. Go to Stores -> Configuration -> Sales -> Sales under Gift Options and set both Allow Gift Messages to YES
  2. Put something in cart and go to checkout or cart page

Expected result

  1. Two forms for gift messages having fields with unique ids

Actual result

  1. Two forms for gift messages having fields with non unique ids
[DOM] Found 2 elements with non-unique id #gift-message-whole-from: (More info: https://goo.gl/9p2vKq) <input type=​"text" id=​"gift-message-whole-from" class=​"input-text" data-bind=​"value:​ getObservable('sender')​">​ <input type=​"text" id=​"gift-message-whole-from" class=​"input-text" data-bind=​"value:​ getObservable('sender')​">

[DOM] Found 2 elements with non-unique id #gift-message-whole-to: (More info: https://goo.gl/9p2vKq) <input type=​"text" id=​"gift-message-whole-to" class=​"input-text" data-bind=​"value:​ getObservable('recipient')​">​ <input type=​"text" id=​"gift-message-whole-to" class=​"input-text" data-bind=​"value:​ getObservable('recipient')​">​

Non unique ids alert appears too in checkout payment choice:

[DOM] Found 2 elements with non-unique id #billing-new-address-form: (More info: https://goo.gl/9p2vKq) <fieldset id=​"billing-new-address-form" class=​"fieldset address">​…​</fieldset>​ <fieldset id=​"billing-new-address-form" class=​"fieldset address">​…​</fieldset>​
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Jan 29, 2018
@magento-engcom-team
Copy link
Contributor

@angelo983, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 30, 2018
@psuthar12
Copy link

@angelo983 did you got any solution for this ? I am getting this error in Magento 2.1.8 even when both Allow Gift Messages are set to No

@ishakhsuvarov ishakhsuvarov mentioned this issue Mar 16, 2018
Closed
@ishakhsuvarov
Copy link
Contributor

Similar report: #14126

@ishakhsuvarov ishakhsuvarov added up for grabs Event: distributed-cd Distributed Contribution Day labels Mar 16, 2018
@EmilyPepperman
Copy link
Contributor

We have this error as well for other elements with non-unique id #... running on Magento 2.2.3 and Gift Options and set both Allow Gift Messages to NO

@ghost
Copy link

ghost commented Mar 29, 2018 •
edited by ghost

Hi @EmilyPepperman I've this similar issue: (in checkout page)

[DOM] Found 2 elements with non-unique id #send2: (More info: https://goo.gl/9p2vKq [^])
<button type=?"submit" class=?"action action-login secondary" name=?"send" id=?"send2">?…?</button>?

Anyone has experienced same situation?

Thanks,

@bmzero
Copy link

bmzero commented Apr 4, 2018

Same situation for me on a new 2.2.3 install.

@mariamghalleb
Copy link

any solution ?

@Deep256 Deep256 self-assigned this Apr 14, 2018
@ghost
Copy link

ghost commented Apr 14, 2018

Also having this problem.

@zennco
Copy link

zennco commented Apr 17, 2018

Similar issue on 2.2.3

[DOM] Found 2 elements with non-unique id #billing-new-address-form:

Noticed that Cash on delivery payment method form had same id (#billing-new-address-form) as Authorize.net method.

Solved by disabling the Cash On Delivery method.

Magento team should use unique html ids for every method templates.

@ghost
Copy link

ghost commented Apr 18, 2018

Hi @Deep256 any update on this? thanks!

@Deep256
Copy link

Deep256 commented Apr 20, 2018

HI @bruno-serfe.
Yes. I want create a pull-request with update today.

@ghost
Copy link

ghost commented Apr 30, 2018

Hi @Deep256 will this be ready in Magento v2.3? thanks

@julienanquetil julienanquetil mentioned this issue May 29, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @angelo983. Thank you for your report.
The issue has been fixed in #15585 by @julienanquetil in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 2, 2018
magento-engcom-team added a commit that referenced this issue Jun 2, 2018
@magento-engcom-team
ENGCOM-1713: Fix #13415 : Duplicated elements id #15585
27435f8 
 - Merge Pull Request #15585 from julienanquetil/magento2:julienanquetil-issue13415
 - Merged commits:
   1. 2e4bd95
   2. 187c529
   3. b90d93d
magento-engcom-team pushed a commit that referenced this issue Jun 2, 2018
@sidolov
ENGCOM-1713: Fix #13415 : Duplicated elements id #15585
6dfcf22
julienanquetil added a commit that referenced this issue Jun 3, 2018
@julienanquetil
Fix #13415 : Duplicated elements id
e5e8911
@ishakhsuvarov ishakhsuvarov removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 20, 2018
@diazwatson
Copy link
Contributor

Hi guys, I am looking at this issue in 2.2-develop (2.2.7-dev) and it seems to be fixed.
Can somebody advise what needs to be done in here?

@diazwatson diazwatson self-assigned this Oct 7, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 7, 2018 •
edited by diazwatson

Hi @diazwatson. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@diazwatson
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @diazwatson. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @diazwatson, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-13415-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@diazwatson
Copy link
Contributor

diazwatson commented Oct 16, 2018 •
edited

Hey guys I am trying to reproduce this issue with the 2.3-develop instance provided but when I try to add a product to the cart I get a message saying:
Your session has expired

Any idea why this is happening?

If this helps, I have also tested that branch in my local environment and the issue seems to be fixed there.

@diazwatson diazwatson removed their assignment Oct 29, 2018
@TomashKhamlai TomashKhamlai self-assigned this Dec 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@TomashKhamlai
Copy link
Contributor

@magento-engcom-team give me 2.3.0 instance

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.3.0 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai, here is your Magento instance.
Admin access: https://i-13415-2-3-0.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@TomashKhamlai TomashKhamlai added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Dec 14, 2018
@TomashKhamlai
Copy link
Contributor

@magento-engcom-team give me 2.2.7 instance

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.2.7 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai, here is your Magento instance.
Admin access: https://i-13415-2-2-7.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@TomashKhamlai
Copy link
Contributor

On 2.3.0 gift-message-whole-to-giftOptionsCartItem-1
screenshot_20181214_153556

@TomashKhamlai TomashKhamlai added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Dec 14, 2018
@TomashKhamlai
Copy link
Contributor

The same on 2.2.7
Also it looks like it needs some cosmetic repair too.

@TomashKhamlai TomashKhamlai added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 14, 2018
@magento-engcom-team
Copy link
Contributor

@TomashKhamlai Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97159, MAGETWO-97160 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 14, 2018
@TomashKhamlai TomashKhamlai removed their assignment Dec 18, 2018
@magento-engcom-team
Copy link
Contributor

Hi @angelo983.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.2.10 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @angelo983.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Checkout Component: GiftMessage Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests