New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated elements id in checkout page #13415

Open
angelo983 opened this Issue Jan 29, 2018 · 38 comments

Comments

@angelo983
Copy link
Contributor

angelo983 commented Jan 29, 2018

Preconditions

  1. Magento 2.1.10

Steps to reproduce

  1. Go to Stores -> Configuration -> Sales -> Sales under Gift Options and set both Allow Gift Messages to YES
  2. Put something in cart and go to checkout or cart page

Expected result

  1. Two forms for gift messages having fields with unique ids

Actual result

  1. Two forms for gift messages having fields with non unique ids
[DOM] Found 2 elements with non-unique id #gift-message-whole-from: (More info: https://goo.gl/9p2vKq) <input type=​"text" id=​"gift-message-whole-from" class=​"input-text" data-bind=​"value:​ getObservable('sender')​">​ <input type=​"text" id=​"gift-message-whole-from" class=​"input-text" data-bind=​"value:​ getObservable('sender')​">
[DOM] Found 2 elements with non-unique id #gift-message-whole-to: (More info: https://goo.gl/9p2vKq) <input type=​"text" id=​"gift-message-whole-to" class=​"input-text" data-bind=​"value:​ getObservable('recipient')​">​ <input type=​"text" id=​"gift-message-whole-to" class=​"input-text" data-bind=​"value:​ getObservable('recipient')​">​

Non unique ids alert appears too in checkout payment choice:

[DOM] Found 2 elements with non-unique id #billing-new-address-form: (More info: https://goo.gl/9p2vKq) <fieldset id=​"billing-new-address-form" class=​"fieldset address">​…​</fieldset>​ <fieldset id=​"billing-new-address-form" class=​"fieldset address">​…​</fieldset>​
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jan 30, 2018

@angelo983, thank you for your report.
We've acknowledged the issue and added to our backlog.

@psuthar12

This comment has been minimized.

Copy link

psuthar12 commented Feb 11, 2018

@angelo983 did you got any solution for this ? I am getting this error in Magento 2.1.8 even when both Allow Gift Messages are set to No

@ishakhsuvarov

This comment has been minimized.

Copy link
Contributor

ishakhsuvarov commented Mar 16, 2018

Similar report: #14126

@EmilyPepperman

This comment has been minimized.

Copy link
Contributor

EmilyPepperman commented Mar 22, 2018

We have this error as well for other elements with non-unique id #... running on Magento 2.2.3 and Gift Options and set both Allow Gift Messages to NO

@bruno-serfe

This comment has been minimized.

Copy link

bruno-serfe commented Mar 29, 2018

Hi @EmilyPepperman I've this similar issue: (in checkout page)

[DOM] Found 2 elements with non-unique id #send2: (More info: https://goo.gl/9p2vKq [^])
<button type=?"submit" class=?"action action-login secondary" name=?"send" id=?"send2">?…?</button>?

Anyone has experienced same situation?

Thanks,

@bmzero

This comment has been minimized.

Copy link

bmzero commented Apr 4, 2018

Same situation for me on a new 2.2.3 install.

@mariamghalleb

This comment has been minimized.

Copy link

mariamghalleb commented Apr 13, 2018

any solution ?

@ishakhsuvarov ishakhsuvarov added this to TODO in Community Dashboard via automation Apr 14, 2018

@Deep256 Deep256 self-assigned this Apr 14, 2018

@Deep256 Deep256 moved this from TODO to Development in Progress in Community Dashboard Apr 14, 2018

@mutantturkey

This comment has been minimized.

Copy link

mutantturkey commented Apr 14, 2018

Also having this problem.

@zennco

This comment has been minimized.

Copy link

zennco commented Apr 17, 2018

Similar issue on 2.2.3

[DOM] Found 2 elements with non-unique id #billing-new-address-form:

Noticed that Cash on delivery payment method form had same id (#billing-new-address-form) as Authorize.net method.

Solved by disabling the Cash On Delivery method.

Magento team should use unique html ids for every method templates.

@bruno-serfe

This comment has been minimized.

Copy link

bruno-serfe commented Apr 18, 2018

Hi @Deep256 any update on this? thanks!

@Deep256

This comment has been minimized.

Copy link

Deep256 commented Apr 20, 2018

HI @bruno-serfe.
Yes. I want create a pull-request with update today.

@bruno-serfe

This comment has been minimized.

Copy link

bruno-serfe commented Apr 30, 2018

Hi @Deep256 will this be ready in Magento v2.3? thanks

@ishakhsuvarov ishakhsuvarov moved this from Development in Progress to TODO in Community Dashboard May 26, 2018

julienanquetil added a commit to julienanquetil/magento2 that referenced this issue May 29, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jun 2, 2018

Hi @angelo983. Thank you for your report.
The issue has been fixed in #15585 by @julienanquetil in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@diazwatson

This comment has been minimized.

Copy link
Collaborator

diazwatson commented Oct 7, 2018

Hi guys, I am looking at this issue in 2.2-develop (2.2.7-dev) and it seems to be fixed.
Can somebody advise what needs to be done in here?

@diazwatson diazwatson self-assigned this Oct 7, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 7, 2018

Hi @diazwatson. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@diazwatson

This comment has been minimized.

Copy link
Collaborator

diazwatson commented Oct 16, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 16, 2018

Hi @diazwatson. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 16, 2018

Hi @diazwatson, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-13415-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@diazwatson

This comment has been minimized.

Copy link
Collaborator

diazwatson commented Oct 16, 2018

Hey guys I am trying to reproduce this issue with the 2.3-develop instance provided but when I try to add a product to the cart I get a message saying:
Your session has expired

Any idea why this is happening?

If this helps, I have also tested that branch in my local environment and the issue seems to be fixed there.

@diazwatson diazwatson removed their assignment Oct 29, 2018

@TomashKhamlai TomashKhamlai self-assigned this Dec 14, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Dec 14, 2018

Hi @TomashKhamlai. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@TomashKhamlai

This comment has been minimized.

Copy link
Contributor

TomashKhamlai commented Dec 14, 2018

@magento-engcom-team give me 2.3.0 instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Dec 14, 2018

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.3.0 instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Dec 14, 2018

Hi @TomashKhamlai, here is your Magento instance.
Admin access: https://i-13415-2-3-0.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@TomashKhamlai

This comment has been minimized.

Copy link
Contributor

TomashKhamlai commented Dec 14, 2018

@magento-engcom-team give me 2.2.7 instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Dec 14, 2018

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.2.7 instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Dec 14, 2018

Hi @TomashKhamlai, here is your Magento instance.
Admin access: https://i-13415-2-2-7.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@TomashKhamlai

This comment has been minimized.

Copy link
Contributor

TomashKhamlai commented Dec 14, 2018

On 2.3.0 gift-message-whole-to-giftOptionsCartItem-1
screenshot_20181214_153556

@TomashKhamlai

This comment has been minimized.

Copy link
Contributor

TomashKhamlai commented Dec 14, 2018

The same on 2.2.7
Also it looks like it needs some cosmetic repair too.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Dec 14, 2018

@TomashKhamlai Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97159, MAGETWO-97160 were created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment