Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Shop By" button disabling broken on the search page #13445

Closed
JanisE opened this issue Jan 31, 2018 · 6 comments
Closed

"Shop By" button disabling broken on the search page #13445

JanisE opened this issue Jan 31, 2018 · 6 comments

Comments

@JanisE
Copy link
Contributor

@JanisE JanisE commented Jan 31, 2018

The "Shop By" button becomes disabled once any additional filters are pointless (they would yield the same one product or no products at all). It works like that on category pages (e.g. "women/tops-women/jackets-women.html"), but it's broken on the search page.

The technical cause is the disabling overlay being positioned below the search results / products on the search page, which is way off the button which is positioned above the search results.

In category pages, the overlay (along with the filtering details) is positioned above the search results.

Preconditions

  1. Magento CE 2.2.2 with sample data is installed by Composer.

Steps to reproduce

  1. click on the "Search" icon and search for "jacket";
  2. resize the window to a mobile size;
  3. click on "Shop By" and choose a filter with one product (e.g. "Category -> Gear");

Expected result

  1. The button "Shop By" should become disabled.

Actual result

  1. The button "Shop By" is still enabled.
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

@magento-engcom-team magento-engcom-team commented Feb 1, 2018

@JanisE, thank you for your report.
We've acknowledged the issue and added to our backlog.

@balaganeshg

This comment has been minimized.

Copy link

@balaganeshg balaganeshg commented May 19, 2018

I am going to work on this issue #dmcdindia

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

@magento-engcom-team magento-engcom-team commented May 19, 2018

@balaganeshg thank you for joining. Please accept team invitation here and self-assign the issue.

@AndreaRivadossi

This comment has been minimized.

Copy link
Contributor

@AndreaRivadossi AndreaRivadossi commented May 29, 2018

Hi, i've analyzed the code in the catalogsearch and in the catalog-category page after adding filters.

I've noticed that in the catalogsearch page is missing the class "page-with-filter" in the body when a filter is added.

I've tried to add manually this class in the code inspector, after i've selected a filter, and if this class is present the code will work correctly, the state filter is displayed immediately after the "shop by" button, and the "shop by" button will be disabled.

So, i think the solution is adding the class "page-with-filter" in the body of the catalogsearch page when a filter is selected, like in the catalog-category page.

I've added the class in the catalogsearch_result_index.xml and seems to work.

Can i send you this modification?

@AndreaRivadossi AndreaRivadossi mentioned this issue May 29, 2018
0 of 4 tasks complete
AndreaRivadossi added a commit to AndreaRivadossi/magento2 that referenced this issue Jun 1, 2018
Added the class for fix the issue magento#13445
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

@magento-engcom-team magento-engcom-team commented Aug 7, 2018

Hi @JanisE. Thank you for your report.
The issue has been fixed in #15650 by @AndreaRivadossi in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

magento-engcom-team added a commit that referenced this issue Aug 7, 2018
#13445 #15650

 - Merge Pull Request #15650 from AndreaRivadossi/magento2:2.2-develop
 - Merged commits:
   1. c55a041
magento-engcom-team pushed a commit that referenced this issue Aug 7, 2018
@sidolov

This comment has been minimized.

Copy link
Contributor

@sidolov sidolov commented Aug 9, 2018

Hi @JanisE. Thank you for your report.
The issue has been fixed in #17418 by @mage2pratik in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team added a commit that referenced this issue Aug 9, 2018
… the search page #13445 #17418

 - Merge Pull Request #17418 from mage2pratik/magento2:2.3-develop-PR-port-15650
 - Merged commits:
   1. 5c310fc
magento-engcom-team pushed a commit that referenced this issue Aug 9, 2018
… the search page #13445 #17418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.