New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick search fires error #14274

Closed
jonathanKingston opened this Issue Mar 22, 2018 · 5 comments

Comments

@jonathanKingston
Copy link
Contributor

jonathanKingston commented Mar 22, 2018

Preconditions

  1. Magento 2.3-develop branch

Steps to reproduce

  1. Type a term into the quick Ajax search field (#search) that doesn't exist in the database
  2. Press Home keyboard key

Expected result

  1. No error

Actual result

  1. TypeError: this._getFirstVisibleElement(...).addClass is not a function
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 23, 2018

@jonathanKingston, thank you for your report.
We've acknowledged the issue and added to our backlog.

@drashmk

This comment has been minimized.

Copy link
Contributor

drashmk commented Mar 24, 2018

I’m working on it #distributed-cd

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 24, 2018

@drashmk thank you for joining. Please accept team invitation here and self-assign the issue.

@drashmk drashmk self-assigned this Mar 24, 2018

@drashmk drashmk moved this from TODO to Development in Progress in Community Dashboard Mar 24, 2018

drashmk added a commit to drashmk/magento2 that referenced this issue Mar 24, 2018

Fixed TypeError: this._getFirstVisibleElement(...).addClass when sear…
…ch term does not exist on pressing Home or End button magento#14274

@drashmk drashmk moved this from Development in Progress to Pull Request In Progress in Community Dashboard Mar 24, 2018

drashmk added a commit to drashmk/magento2 that referenced this issue Mar 24, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 26, 2018

Hi @jonathanKingston. Thank you for your report.
The issue has been fixed in #14301 by @drashmk in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team added a commit that referenced this issue Mar 26, 2018

ENGCOM-1057: Fixed TypeError when search term does not exist on press…
…ing Home or End button #14274 #14301

 - Merge Pull Request #14301 from drashmk/magento2:14274-quick-search
 - Merged commits:
   1. bd47df7
   2. 98be34b
   3. a5252de

magento-engcom-team pushed a commit that referenced this issue Mar 26, 2018

@sidolov sidolov removed this from Pull Request In Progress in Community Dashboard Apr 14, 2018

@magento-engcom-team magento-engcom-team added this to TODO in Community Dashboard via automation Apr 14, 2018

julienanquetil added a commit to julienanquetil/magento2 that referenced this issue Apr 24, 2018

@julienanquetil julienanquetil moved this from TODO to Done in Community Dashboard Apr 24, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 26, 2018

Hi @jonathanKingston. Thank you for your report.
The issue has been fixed in #14839 by @julienanquetil in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment