Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press Esc Key on modal generate a jquery UI error #14593

Closed
apomili opened this issue Apr 9, 2018 · 7 comments
Closed

Press Esc Key on modal generate a jquery UI error #14593

apomili opened this issue Apr 9, 2018 · 7 comments
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update

Comments

@apomili
Copy link

apomili commented Apr 9, 2018

If you add a product in the cart, then you press the trash icon to delete it a modal window will appear.
If you press the "Esc" key, this js error is raised

  • Precondition: I suppose every version of Magento with Luma Theme,
    like this demo http://demo-acm2.bird.eu (ver 2.2.3)

  • Step to reproduce: Add a product in the cart. From the mini cart in the upper right click the trash icon. A confirmation modal will open. Press Esc button

  • Expected result: Modal close

  • Actual result: Uncaught TypeError: Cannot read property 'stopImmediatePropagation' of undefined
    at Object.always (sidebar.js:81)

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Apr 9, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 4, 2018

Hi @apomili thank you for your report.
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please, add the following information:

  • Preconditions: Magento version
  • Steps to reproduce
  • Expected result
  • Actual result

@apomili
Copy link
Author

apomili commented Jun 5, 2018

Done

@0m3r
Copy link
Contributor

0m3r commented Jun 21, 2018

reproduced on Magento 2.2.4

Preconditions: Magento version 2.2.4 with luma theme

Step to reproduce:

  • Open chrome developer console
  • Add a product to the cart.
  • From the mini cart in the upper right click the trash icon.
  • A confirmation modal will open.
  • Press Esc button

Expected Result

  • Close the confirm

Actual result

  • js error

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96

Uncaught TypeError: Cannot read property 'stopImmediatePropagation' of undefined

2018-06-21 15-50-01

@0m3r
Copy link
Contributor

0m3r commented Jun 21, 2018

Proposal fix

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96

                        always: function (e) {
                            if (e && typeof e.stopImmediatePropagation === 'function') {
                                e.stopImmediatePropagation();
                            }
                        }

This was referenced Jun 27, 2018
@VladimirZaets VladimirZaets added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 3, 2018
@VladimirZaets
Copy link
Contributor

Hi @apomili. Thank you for your report.
The issue has been fixed in #16477 by @0m3r in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

magento-engcom-team added a commit that referenced this issue Jul 3, 2018
 - Merge Pull Request #16477 from 0m3r/magento2:2.2-develop
 - Merged commits:
   1. 8399f63
   2. a6a17d3
   3. 21f85b4
@sidolov
Copy link
Contributor

sidolov commented Jul 11, 2018

Hi @apomili. Thank you for your report.
The issue has been fixed in #16623 by @mageprince in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 11, 2018
magento-engcom-team added a commit that referenced this issue Jul 11, 2018
 - Merge Pull Request #16623 from mageprince/magento2:2.3-develop-PR-port-16477
 - Merged commits:
   1. 0fdc0a8
   2. 07f7d83
   3. 160bc5d
gelanivishal pushed a commit to gelanivishal/magento2 that referenced this issue Jul 28, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 1, 2018

Hi @apomili. Thank you for your report.
The issue has been fixed in #17223 by @gelanivishal in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Aug 1, 2018
magento-engcom-team added a commit that referenced this issue Aug 1, 2018
 - Merge Pull Request #17223 from gelanivishal/magento2:2.1-develop-PR-port-16477
 - Merged commits:
   1. b50caeb
   2. 540cdb5
   3. d937ca7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update
Projects
None yet
Development

No branches or pull requests

5 participants