Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the bug about when i change local language #1547

Closed
LifeAsBook opened this issue Jul 23, 2015 · 7 comments
Closed

the bug about when i change local language #1547

LifeAsBook opened this issue Jul 23, 2015 · 7 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@LifeAsBook
Copy link

the bug about when i change local language use chinese in "zh_Hans_CN" but the zh_CN.csv file is not used . i think the zh_CN.csv is default of all chineses when zh_Hans_CN.csv does not exist
@vpelipenko
Copy link
Contributor

@LifeAsBook, it is not true. If you want to use zh_Hans_CN you should have zh_Hans_CN.csv. There is no fallback to zh_CN.

@LifeAsBook
Copy link
Author

@vpelipenko, all Magento modules have default zh_CN.csv but not to use in anywhere

@vpelipenko
Copy link
Contributor

It will be used if you set zh_CN locale for your store.

@LifeAsBook
Copy link
Author

@vpelipenko i mean is the backend manager Interface Locale have no zh_CN . only have zh_Hans_CN,zh_Hant_HK,zh_Hant_TW
23

@LifeAsBook
Copy link
Author

@vpelipenko hi

@vpelipenko
Copy link
Contributor

@LifeAsBook, I see, thank you for pointing this. It looks like a bug. Internal ticket: MAGETWO-41378.

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report and removed question labels Aug 11, 2015
@piotrekkaminski
Copy link
Contributor

It should be fixed now.

magento-team pushed a commit that referenced this issue Oct 6, 2015
MAGETWO-41378: [GITHUB] the bug about when i change local language #1547
bd488ec 


- Changed 'zh_Hans_CN' to 'zh_CN' in config.php
- Added 'zh_CN' to the list of locales retrieved by ResourceBundle.
- Now chinese translation works for both admin interface and webfront.
magento-team pushed a commit that referenced this issue Oct 6, 2015
MAGETWO-41378: [GITHUB] the bug about when i change local language #1547
c1c0b59 


- Updated Unit Test.
magento-team pushed a commit that referenced this issue Oct 6, 2015
MAGETWO-41378: [GITHUB] the bug about when i change local language #1547
7c662a4 


- Changed all i18n zh_CN.csv files to zh_Hans_CN.csv
- Changed the regexp pattern that accepts languages to accomodate for zh_Hans_CN different pattern.
- Reverted back my previous changes of Config.php, ConfigTest.php, TranslatedLists.php and Lists.php
- Updated the composer file of zh_CN.
magento-team pushed a commit that referenced this issue Oct 6, 2015
MAGETWO-41378: [GITHUB] the bug about when i change local language #1547
c3e8150 


- Updated composer.json with new language name (along with composer.lock so test wont fail).
- Updated composerTest Integrity test with new language regexp.
magento-team pushed a commit that referenced this issue Oct 6, 2015
MAGETWO-41378: [GITHUB] the bug about when i change local language #1547
7b02c6e 


- Updated regex pattern
magento-team pushed a commit that referenced this issue Oct 6, 2015
MAGETWO-41378: [GITHUB] the bug about when i change local language #1547
03b3ea2 


- Reverted the file permissions that I changed by mistake.
cspruiell referenced this issue Oct 6, 2015
Merge remote-tracking branch 'remotes/api/MAGETWO-41378-GITHUB-the-bu…
108d0d6 
…g-about-when-i-change-local-language-#1547' into API-Sprint-58-PR

# Conflicts:
#	composer.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piotrekkaminski @vpelipenko @LifeAsBook