Method $product->getUrlInStore() returning extremely long URLs, could be a bug

[adampmoss]

I feel like there may be a bug in the following file because the output of $product->getUrlInStore() is not what I'd expect. Query params related to the store are added to the URL in the following file:

magento2/app/code/Magento/Store/Url/Plugin/RouteParamsResolver.php

Line 66 in 9c14af7

$storeCode = $subject->getScope() ?: $this->storeManager->getStore()->getCode();

By setting an entire object ($subject->getScope()) as the $storeCoderather than just a string default it is causing a very messy looking URL.

Preconditions

1. Have a Magento installation with more than 1 store
2. Add store code to URLs in configuration is set to "no"
3. Magento version 2.2.3

Steps to reproduce

Use the following code where a product model is loaded and where you can see the result:

<?= $product->getUrlInStore() ?>

Expected result

The URL produced for the product would look like:

https://www.domain.com/my-product.html?___store=default

Actual result

The URL produced is actually very long winded:

https://www.domain.com/my-product.html?___store%5B_data%5D%5Bstore_id%5D=1&___store%5B_data%5D%5Bcode%5D=default&___store%5B_data%5D%5Bwebsite_id%5D=1&___store%5B_data%5D%5Bgroup_id%5D=1&___store%5B_data%5D%5Bname%5D=UK+Mainland&___store%5B_data%5D%5Bsort_order%5D=0&___store%5B_data%5D%5Bis_active%5D=1&___store%5B_data%5D%5Bavailable_currency_codes%5D%5B0%5D=GBP&___store%5B_data%5D%5Bbase_currency%5D%5B_data%5D%5Bcurrency_code%5D=GBP&___store%5B_data%5D%5Bcurrent_currency%5D%5B_data%5D%5Bcurrency_code%5D=GBP

[vasilii-b]

This can be reproduced on Magento 2.3-develop as well.
And actually from steps to reproduce there is another bug: Having Add store code to URLs set to NO, still shows you the URL like https://www.domain.com/my-product.html?___store=default.

[vasilii-b]

According to the file /app/code/Magento/Store/Url/Plugin/RouteParamsResolver.php and its content, this issue is reproducible on Magento 2.2-develop and Magento 2.1-develop.