Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect displaying Product Image Watermarks on Magento 2.2.5 #16929

Closed
dzima-chyzhou opened this issue Jul 19, 2018 · 11 comments
Closed

Incorrect displaying Product Image Watermarks on Magento 2.2.5 #16929

dzima-chyzhou opened this issue Jul 19, 2018 · 11 comments
Labels
Component: Catalog Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@dzima-chyzhou
Copy link

dzima-chyzhou commented Jul 19, 2018

Summary

Background of Product Image Watermarks is displayed incorrect if it is transparent.

Preconditions

  1. Magento 2.2.5 CE with sample data
  2. PHP 7.0.30

Steps to reproduce

  1. Login to Admin Panel
  2. Create a simple product with any configuration and upload any product image (the image that I uploaded below)
    mb01-blue-0
  3. Go to Content -> Design -> Configuration
  4. Click on the edit action on the Global Magento Luma theme
  5. Go to the Product Image Watermarks section
  6. Upload any PNG image with a transparent background for example in the small category (the image that I uploaded below)
    58480ecccef1014c0b5e492c
  7. Set Image Opacity to 10
  8. Set Image Size to 40x50
  9. Set Image Position Tile
  10. Save Configuration
  11. Go to the product view on store front and look at the result

Expected result

  1. Product Image Watermarks are displayed over a product image
  2. Image Watermarks size is 40x50
  3. Image Watermarks position is tile
  4. Image Watermarks opasity is 10
  5. Background of Image Watermarks is transparent as it is transparent on an uploaded image

Actual result

  1. Product Image Watermarks are displayed over a product image
  2. Image Watermarks size is 40x50
  3. Image Watermarks position is tile
  4. Image Watermarks opacity is 10
  5. Background of Image Watermarks IS NOT transparent.
    screenshot from 2018-07-19 10-35-21
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chizhov13. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@chizhov13 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@dzima-chyzhou
Copy link
Author

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Contributor

Hi @chizhov13. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @chizhov13, here is your Magento instance.
Admin access: https://i-16929-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@dzima-chyzhou
Copy link
Author

@magento-engcom-team yes. I am able to reproduse this issue. Just go to the product view on the store front and look at the result.

@engcom-backlog-nickolas engcom-backlog-nickolas added Component: Catalog Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Jul 19, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas removed their assignment Jul 19, 2018
@engcom-backlog-nickolas

Hello @chizhov13, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ronak2ram
Copy link
Member

Hello @chizhov13
Can you please check solution #17013

@dzima-chyzhou
Copy link
Author

Hello @ronak2ram thank you for your response.

I checked your solution on Magento 2.2.5, everything is okey. But then I have tried to reproduce this bug on Magento 2.1.14 and it still does not work properly.

I see that this issue is opened for 2.2.x and 2.3.x. but also need to fix it on Magento 2.1.x

@salehawal
Copy link

@ronak2ram thanks it is working now on magento 2.2.4

@magento-engcom-team
Copy link
Contributor

Hi @chizhov13. Thank you for your report.
The issue has been fixed in #17013 by @ronak2ram in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Aug 15, 2018
magento-engcom-team added a commit that referenced this issue Aug 15, 2018
…arks on Magento 2.2.5 #17013

 - Merge Pull Request #17013 from ronak2ram/magento2:ronak2ram-patch-4
 - Merged commits:
   1. 3259f5a
   2. ae24b01
magento-engcom-team pushed a commit that referenced this issue Aug 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chizhov13. Thank you for your report.
The issue has been fixed in #17623 by @ronak2ram in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 13, 2018
magento-engcom-team added a commit that referenced this issue Sep 13, 2018
…t Image Watermarks on Magento 2.2.5 #17623

 - Merge Pull Request #17623 from ronak2ram/magento2:2.3-develop-PR-port-17013
 - Merged commits:
   1. 686406a
magento-engcom-team pushed a commit that referenced this issue Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants