Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16929 - Incorrect displaying Product Image Watermarks on Magento 2.2.5 #17013

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Jul 23, 2018

Description

Not needed to call function imagealphablending() when resize watermark size.

Fixed Issues

  1. Incorrect displaying Product Image Watermarks on Magento 2.2.5 #16929: Incorrect displaying Product Image Watermarks on Magento 2.2.5

Manual testing scenarios

  1. Login to Admin Panel
  2. Create a simple product with any configuration and upload any product image (the image that I uploaded below)
    mb01-blue-0
  3. Go to Content -> Design -> Configuration
  4. Click on the edit action on the Global Magento Luma theme
  5. Go to the Product Image Watermarks section
  6. Upload any PNG image with a transparent background for example in the small category (the image that I uploaded below)
    58480ecccef1014c0b5e492c
  7. Set Image Opacity to 10
  8. Set Image Size to 40x50
  9. Set Image Position Tile
  10. Save Configuration
  11. Go to the product view on store front and look at the result

Result

screenshot4

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ronak2ram
Copy link
Member Author

@magento-engcom-team
Have you checked this solution?

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants