Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"- undefined" displayed in checkout summary when shipping method name is not set #17492

Closed
krzksz opened this issue Aug 10, 2018 · 12 comments
Closed
Labels
Component: Shipping Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@krzksz
Copy link
Contributor

krzksz commented Aug 10, 2018

Sometimes it is the case that setting both Carrier title and Method name for a shipping method is redundant and having only the first one set it totally enough. Sadly, in the case of leaving Method name field blank there is a small visual bug displayed in checkout summary box.

Preconditions

  1. Magento 2.2.x, but any version may be affected
  2. Shipping method with empty Method Name set.

Steps to reproduce

  1. Add new or edit any existing shipping methods with Method name field left as a blank field.
  2. Add any product to the cart and go through the checkout to the last step.

Expected result

  1. Shipping method is displayed nicely.

Actual result

  1. There is a - undefined string displayed.

obraz

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 10, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 10, 2018

Hi @krzksz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@krzksz do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@krzksz
Copy link
Contributor Author

krzksz commented Aug 10, 2018

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, here is your Magento instance.
Admin access: https://i-17492-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost self-assigned this Aug 10, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Shipping Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 10, 2018
@ghost
Copy link

ghost commented Aug 10, 2018

@krzksz , thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Aug 10, 2018
@gelanivishal gelanivishal self-assigned this Aug 11, 2018
VladimirZaets added a commit to gelanivishal/magento2 that referenced this issue Aug 12, 2018
@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Aug 13, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Aug 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your report.
The issue has been fixed in #17526 by @gelanivishal in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

magento-engcom-team added a commit that referenced this issue Aug 14, 2018
 - Merge Pull Request #17526 from gelanivishal/magento2:issue-17492
 - Merged commits:
   1. c789fb2
   2. 7aecb1f
gelanivishal pushed a commit to gelanivishal/magento2 that referenced this issue Aug 20, 2018
gelanivishal added a commit to gelanivishal/magento2 that referenced this issue Aug 20, 2018
[Forwardport] Fixed undefinded shipping method name issue magento#17492
VladimirZaets added a commit to gelanivishal/magento2 that referenced this issue Sep 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your report.
The issue has been fixed in #17697 by @gelanivishal in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 13, 2018
magento-engcom-team added a commit that referenced this issue Sep 13, 2018
…#17492 #17697

 - Merge Pull Request #17697 from gelanivishal/magento2:2.3-develop-PR-port-17526-2
 - Merged commits:
   1. 667e276
   2. d85dd69
   3. cd7c2b1
@orlangur
Copy link
Contributor

This seems to be not fixed completely according to new linked PR.

@orlangur orlangur reopened this Apr 16, 2019
@ghost ghost unassigned gelanivishal Apr 16, 2019
@ghost ghost removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Apr 16, 2019
@ghost ghost assigned basvanpoppel Apr 16, 2019
@orlangur orlangur removed Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Apr 16, 2019
@ghost ghost unassigned basvanpoppel Jun 25, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jun 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2019

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 27, 2019
@ghost ghost unassigned engcom-Alfa Jun 27, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-17845, MC-17846 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 27, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.2.10 release.

@magento-engcom-team
Copy link
Contributor

Hi @krzksz.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Shipping Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants