Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Special Prices not correctly rounded #17638

Closed
Stassy opened this issue Aug 16, 2018 · 7 comments
Closed

Bundle Special Prices not correctly rounded #17638

Stassy opened this issue Aug 16, 2018 · 7 comments
Labels
Component: Bundle Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Stassy
Copy link

Stassy commented Aug 16, 2018

When adding a Special Price to a bundle like 78,9473% (4 decimals), it's saved ok in the database.
If you load the same bundle and save again, it's changed to 78.95% (2 decimals)

Preconditions

  1. Magento 2.2.5 (able to reproduce everytime)

Steps to reproduce

  1. Create one product with price 760€
  2. Create a bundle with this product
  3. Set a special price to this bundle to 78.9473%
    (I want price of this bundle to be 600€. So 600€ / 760€ = 0,7894736842)
  4. Save bundle only ONCE !!!!! (DO NOT RELOAD IT, DO NOT SAVE A SECOND TIME)
  5. Check in DB : SELECT * FROM catalog_product_entity_decimal WHERE attribute_id = 78;
    value is 78.9473
  6. Open bundle again and go to Advanced pricing --> Value is 78.95%
  7. Don't touch anything and Save bundle
  8. Check in DB : SELECT * FROM catalog_product_entity_decimal WHERE attribute_id = 78;
    value is 78.95
  9. As a final result in the shop, bundle price is 600,01€

Expected result

  1. In Step 6, expected value should be the one in database : 78,9473% (not rounded)

Actual result

  1. In Step 6, value is rounded to 2 decimals at 78.95%

EXTRA INFO

Maybe a link with this issue from PierreLeMaguer : #15311

Thanks

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Stassy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@Stassy do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@Stassy
Copy link
Author

Stassy commented Aug 16, 2018

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Contributor

Hi @Stassy. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Stassy, here is your Magento instance.
Admin access: https://i-17638-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost self-assigned this Aug 16, 2018
@Stassy
Copy link
Author

Stassy commented Aug 16, 2018

@magento-engcom-team I confirm I can reproduce it on Vanilla

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Bundle Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 16, 2018
@ghost
Copy link

ghost commented Aug 16, 2018

@Stassy , thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Aug 16, 2018
@jaimin-ktpl jaimin-ktpl self-assigned this Aug 18, 2018
@jaimin-ktpl jaimin-ktpl removed their assignment Sep 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Stassy. Thank you for your report.
The issue has been fixed in #17971 by @magently in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Bundle Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants