Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento version 2.2.6 Alert widget gets close when click anywhere on screen #18458

Closed
asgarh opened this issue Oct 8, 2018 · 13 comments
Closed
Assignees
Labels
Event: squashtoberfest Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@asgarh
Copy link

asgarh commented Oct 8, 2018

Preconditions

  1. Magento version 2.2.6

Steps to reproduce

  1. Add product to cart
    2.Click on the cart icon at right top of screen
    3.Click on delete icon
    4.Now click any where on screen the alert widget will close

Expected result

1.The alert widget should not close until user click cancel button
2.

Actual result

  1. Alert widget gets close when click any where on screen
@magento-engcom-team
Copy link
Contributor

Hi @asgarh. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@asgarh do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 8, 2018
@asgarh
Copy link
Author

asgarh commented Oct 8, 2018

@magento-engcom-team give me 2.2.6 instance

@magento-engcom-team
Copy link
Contributor

Hi @asgarh. Thank you for your request. I'm working on Magento 2.2.6 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @asgarh, here is your Magento instance.
Admin access: https://i-18458-2-2-6.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@asgarh
Copy link
Author

asgarh commented Oct 8, 2018

Yes, I am able to reproduce the issue on vanilla Magento instance

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@Shubham0492
Copy link

#SQUASHTOBERFEST

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 29, 2018
magento-engcom-team added a commit that referenced this issue Oct 29, 2018
…anywhere on screen #18576 #18865

 - Merge Pull Request #18865 from Shubham-Webkul/magento2:Shubham-18458-2
 - Merged commits:
   1. f59bc17
   2. 06b243f
   3. c3bc361
   4. 26a9520
   5. 87167e7
   6. c6586ab
   7. d40a26c
   8. 84c7391
   9. e1483f6
   10. 3b2e4e4
   11. 7dc2d1b
@Shubham0492
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18458-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@florincyberion
Copy link

This is wrong and should be reverted. That was the normal expected behaviour with clickableOverlay on.

@fgerodez
Copy link

This should never have been merged, it broke a basic and correctly working feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: squashtoberfest Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

5 participants