Product list sort order is saved but not used

[michi-p]

Preconditions (*)

1. Magento CE version 2.2.6
2. PHP 7.1.25
3. At least two categories with an arbitrary number of products each.

Steps to reproduce (*)

1. Open a category in your shop (e. g. shop.example.com/food.html)
2. Change the sort order (e. g. from 'position' to 'name'). URL changes to shop.example.com/food.html?product_list_order=name
3. Switch to other category (e. g. shop.example.com/drinks.html)

Expected result (*)

1. The products of the category drinks should be shown sorted by their names

Actual result (*)

1. The products of the category drinks are shown sorted by position (default value)

Additional information

The function \Magento\Catalog\Block\Product\ProductList\Toolbar::getCurrentOrder calls the method _memorizeParam where the selected sort order is saved in the catalog session. (It's not disabled in my case, the function setData is called and the saved value is correct as well).
However, this session value seems to be not used again anywhere.

[magento-engcom-team]

Hi @michi-p. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@michi-p do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

Hi @michi-p thank you for you report, It will be processed faster if you move this to https://github.com/magento/community-features

[fritzmg]

@engcom-backlog-nazar This is not a feature request. Magento 1.x supports this functionality by default and Magento 2.x already saves the last sort order in the session. However, it never actually reads the last sort order from the session, as explained in the original post.

@fritzmg but this is magento 2 not one. so this is feature.

[fritzmg]

As already said,

Magento 2.x already saves the last sort order in the session.

Yet, it does not use it anywhere. Why would that be on purpose?

@fritzmg ok can you provide more information ? so we can edit this issue and report as issue.

[fritzmg]

@engcom-backlog-nazar the necessary information is already posted here: #21076 (comment)

The function \Magento\Catalog\Block\Product\ProductList\Toolbar::getCurrentOrder calls the method _memorizeParam where the selected sort order is saved in the catalog session.
However, this session value seems to be not used again anywhere.

magento2/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php

Lines 252 to 254 in 32e14db

	if ($order != $defaultOrder) {
	$this->_memorizeParam('sort_order', $order);
	}

magento2/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php

Lines 169 to 175 in 32e14db

	protected function _memorizeParam($param, $value)
	{
	if ($this->_paramsMemorizeAllowed && !$this->_catalogSession->getParamsMemorizeDisabled()) {
	$this->_catalogSession->setData($param, $value);
	}
	return $this;
	}

The sort_order parameter is saved in the session, but never loaded from the session anywhere again. The same applies to sort_direction by the way.