Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Order - Email is Now Required - Magento 2.2.6 #22251

Open
trucatchtraps opened this issue Apr 9, 2019 · 22 comments

Comments

@trucatchtraps
Copy link

commented Apr 9, 2019

Preconditions (*)

  1. Magento 2.2.6 and newer

Steps to reproduce (*)

  1. Sales -> Orders
  2. Create New Order
  3. Create New Customer
  4. Select Store View or if Single-Store Mode it brings you to the Order Information Page
  5. Email field is now required

Expected result (*)

  1. Email field is NOT required (like versions prior to 2.2.6)

Actual result (*)

  1. Email field is required

Additional Information (*)

The email field has never been required prior to 2.2.6 even going back to Magento1. Now the email field is required when placing an order on the backend of Magento. There is absolutely no documentation about this change or at least I have not found any. I will revert it with a custom module myself if someone points me to the code that makes it a required field. This needs to be a Config option to have the email required or not required. This is causing us major issues because now we have to try and make up random email address for customers. Not all the people in this world have an email address and some just prefer not to give it out. This is a bug not a feature. Please do not tell me this is normal function of Magento when it hasn't been since the beginning of Magento.

Screenshots (*)

Magento 2.2.4
IxikJ

Magento 2.2.6
iWVci

@m2-assistant

This comment has been minimized.

Copy link

commented Apr 9, 2019

Hi @trucatchtraps. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@trucatchtraps do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@m2-backlog m2-backlog bot added this to Ready for QA in Community Backlog Apr 9, 2019

@trucatchtraps trucatchtraps changed the title Admin Order Email is Now Required - Magento 2.2.6 Admin Order - Email is Now Required - Magento 2.2.6 Apr 9, 2019

@engcom-backlog-nazar engcom-backlog-nazar self-assigned this Apr 10, 2019

@m2-assistant

This comment has been minimized.

Copy link

commented Apr 10, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-backlog-nazar

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@magento-engcom-team give me 2.2.3 instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Hi @engcom-backlog-nazar. Thank you for your request. I'm working on Magento 2.2.3 instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Hi @engcom-backlog-nazar, here is your Magento instance.
Admin access: https://i-22251-2-2-3.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-backlog-nazar

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

HI @trucatchtraps thank you for you report, this is the "big issue" to have a not required email, and this was included in CHANGELOG.md, so there is a issue in older version where this field was not required.
DeepinScreenshot_select-area_20190410100110

@m2-backlog m2-backlog bot moved this from Ready for QA to Done in Community Backlog Apr 10, 2019

@trucatchtraps

This comment has been minimized.

Copy link
Author

commented Apr 10, 2019

That field has never been required in all my time working with Magento. Why is there now an issue with the email not required? And this is for backend orders. I just don't understand why it needs to be required for backend orders. Do you have a commit for the changes? I would like to override them.

@driskell

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@engcom-backlog-nazar Please can we reopen.

The changelog appears to refer to frontend guest checkout and not backend MOTO orders which have never required email and instead generated a random example.com placeholder email.

The configuration for the default email domain actually still exists so this is a bug. Default should be not required for MOTO (they are taking telephone calls to place orders - most users here do not have email addresses)

F5F02FDA-BF7B-4F14-BAC8-4B788E4DA7D5

@driskell driskell reopened this Apr 18, 2019

@m2-backlog m2-backlog bot moved this from Done to Ready for QA in Community Backlog Apr 18, 2019

@driskell

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

The commit that rolled back this feature was here:

b1eece2#diff-b79fbcef70631d52e90840aaf9a0d94d

@joanhe do you know what the reason for removing this feature was? The commit has actually left the constant and the configuration itself dangling with no use. Would be great to see this restored for next version and if necessary made optional.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99353, MAGETWO-99354 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@trucatchtraps

This comment has been minimized.

Copy link
Author

commented Apr 29, 2019

I tried reverting that commit with a custom module but received the same results of the email being required on admin order.

@driskell

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@trucatchtraps We reverted the commit mentioned above and it restored original functionality perfectly. No longer required, and when left blank, auto-generates using the Default Email Domain

@trucatchtraps

This comment has been minimized.

Copy link
Author

commented May 2, 2019

I must have missed something then...will try again

@trucatchtraps

This comment has been minimized.

Copy link
Author

commented May 2, 2019

@driskell - I have tried it a couple different ways but still not showing the override for Magento\Sales\Block\Adminhtml\Order\Create\Form\Account on the backend. Can you please take a look at the custom module I created? The attached files I try to override the whole file, I have also tried to extend the original file and only include the affected classes but neither seems to be working.

Trucatch.zip

Thanks!

@m2-backlog m2-backlog bot moved this from Ready for Dev to Good First Issue in Community Backlog May 3, 2019

@solwininfotech

This comment has been minimized.

Copy link

commented May 4, 2019

I am working on this at #dmcdindia19

@m2-assistant

This comment has been minimized.

Copy link

commented May 4, 2019

Hi @solwininfotech. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-backlog m2-backlog bot moved this from Good First Issue to Dev in Progress in Community Backlog May 4, 2019

@m2-backlog m2-backlog bot moved this from Dev in Progress to PR In Progress in Community Backlog May 4, 2019

@jayachandraoggy

This comment has been minimized.

Copy link

commented May 28, 2019

@magento-engcom-team give me 2.2.6 instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Hi @jayachandraoggy. Thank you for your request. I'm working on Magento 2.2.6 instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Hi @jayachandraoggy, here is your Magento instance.
Admin access: https://i-22251-2-2-6.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@jayachandraoggy

This comment has been minimized.

Copy link

commented May 28, 2019

I am working on this #codilar

@trucatchtraps

This comment has been minimized.

Copy link
Author

commented Jun 19, 2019

Any update to this? I am still not able to revert the commit using a custom module. I moved to 2.3.1 but the issue is still present. I reattached my custom module, if someone wouldn't mind taking a look quick

Trucatch.zip

@trucatchtraps

This comment has been minimized.

Copy link
Author

commented Jun 20, 2019

I finally was able to remove the required * for the email address, but now when I try to place an order without an email address, I receive the following errors.

The value of attribute "Email" must be set
Validation is failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.