[Grouped product] Can´t add simple products to cart if one other is out of stock #22304

hamplr · 2019-04-12T12:24:35Z

Preconditions (*)

magento 2.2-develop
php 7.1

Steps to reproduce (*)

enable the option allow to show products without stock
grouped product with more sub items
at least one sub items have to be without stock (quantity=0)
navigate to the PDS of the grouped product
add at least on item of any available sub item
if you add the item to the cart the message "Please specify the quantity of product(s)." apears

Expected result (*)

the simple products are added to the cart

Actual result (*)

the message "Please specify the quantity of product(s)." appears
it´s not possible to add a simple product, if one other simple product within the grouped product is out of stock

m2-assistant · 2019-04-12T12:24:36Z

Hi @hamplr. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@hamplr do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

m2-assistant · 2019-04-12T12:44:20Z

Hi @larsroettig. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

larsroettig · 2019-04-12T13:02:48Z

@magento-engcom-team give me 2.2-develop instance

larsroettig · 2019-04-12T13:02:54Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-04-12T13:03:58Z

Hi @hamplr. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team · 2019-04-12T13:04:44Z

Hi @larsroettig. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team · 2019-04-12T13:04:45Z

Hi @larsroettig. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-04-12T13:04:47Z

Hi @hamplr, here is your Magento instance.
Admin access: https://i-22304-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

nickpiro · 2019-04-17T20:05:54Z

Having the same issue in 2.2.8

larsroettig · 2019-04-18T09:19:12Z

Hi @nickpiro,
we have a fix as Patch for 2.2.8 currently it is not possible to fix this without breaking the Backward compatiblty. Maybee we will find way but I must ask the Team,

Index: project/src/vendor/magento/module-grouped-product/Model/Product/Type/Grouped.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- vendor/magento/module-grouped-product/Model/Product/Type/Grouped.php
+++ vendor/magento/module-grouped-product/Model/Product/Type/Grouped.php
@@ -338,9 +338,6 @@
         }
         foreach ($associatedProducts as $subProduct) {
             if (!isset($productsInfo[$subProduct->getId()])) {
-                if ($isStrictProcessMode && !$subProduct->getQty()) {
-                    return __('Please specify the quantity of product(s).')->render();
-                }
                 $productsInfo[$subProduct->getId()] = $subProduct->isSalable() ? (float)$subProduct->getQty() : 0;
             }
         }

celorodovalho · 2019-04-23T09:25:15Z

I have the same problem here in 2.2.8
Any solution?
This is a blocking issue!

@larsroettig there is a commit for this patch?

hamplr · 2019-04-23T11:36:20Z

No, there´s currently no commit for this patch, but we have the patch in use in our project to solve the problem.

m2-assistant · 2019-05-11T06:09:10Z

Hi @mallikaverma. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

Join Magento Community Engineering Slack and ask your questions in #github channel.

mallikaverma · 2019-05-11T06:11:25Z

@magento-engcom-team give me 2.3-develop instance

mallikaverma · 2019-05-11T16:26:46Z

I am working on it

mallikaverma · 2019-05-12T17:48:14Z

#imagine2019

joekersh · 2019-05-13T10:08:42Z

The fix from @larsroettig works for me, i created a preference for that class and then overrode the getProductInfo method:

In your module di.xml:

<preference for="Magento\GroupedProduct\Model\Product\Type\Grouped" type="Vendor\Module\Model\Grouped"/>

New class Vendor\Module\Model\Grouped:

protected function getProductInfo(\Magento\Framework\DataObject $buyRequest, $product, $isStrictProcessMode)
{
    $productsInfo = $buyRequest->getSuperGroup() ?: [];
    $associatedProducts = $this->getAssociatedProducts($product);

    if (!is_array($productsInfo)) {
        return __('Please specify the quantity of product(s).')->render();
    }
    foreach ($associatedProducts as $subProduct) {
        if (!isset($productsInfo[$subProduct->getId()])) {
        	
            // if ($isStrictProcessMode && !$subProduct->getQty()) {
            //     return __('Please specify the quantity of product(s).')->render();
            // }
            
            $productsInfo[$subProduct->getId()] = $subProduct->isSalable() ? (float)$subProduct->getQty() : 0;
        }
    }

    return $productsInfo;
}

`

larsroettig · 2019-05-13T10:22:43Z

@joekersh preference is not the best way to solve this issue patching is a better way yesterday @mallikaverma creating a pr this look backwards compatible.

m2-assistant · 2019-05-27T13:49:58Z

Hi @dmytro-ch. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team · 2019-05-27T14:17:21Z

✅ Confirmed by @dmytro-ch
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99841 were created

Issue Available: @dmytro-ch, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

reense · 2019-06-14T14:30:31Z

I can confirm that @larsroettig 's solution is working. Thanks !

VladimirZaets · 2020-01-17T18:13:08Z

Hi @hamplr. Thank you for your report.
The issue has been fixed in #24955 by @gihovani in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 12, 2019

larsroettig self-assigned this Apr 12, 2019

mallikaverma self-assigned this May 11, 2019

magento-engcom-team added the Event: imagine2019 label May 12, 2019

mallikaverma mentioned this issue May 12, 2019

Resolved issue #22845

Closed

4 tasks

dmytro-ch self-assigned this May 27, 2019

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 27, 2019

magento-engcom-team unassigned dmytro-ch May 27, 2019

ghost unassigned mallikaverma Jun 13, 2019

ghost unassigned larsroettig Sep 27, 2019

gihovani mentioned this issue Oct 9, 2019

Fix: add to cart grouped product when exists a sold out option #24955

Merged

4 tasks

ghost assigned gihovani Dec 5, 2019

VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 17, 2020

VladimirZaets closed this as completed Jan 17, 2020

sdzhepa mentioned this issue May 9, 2022

tyutyu sdzhepa/magento2#5

Open

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Grouped product] Can´t add simple products to cart if one other is out of stock #22304

[Grouped product] Can´t add simple products to cart if one other is out of stock #22304

hamplr commented Apr 12, 2019 •

edited by larsroettig

Loading

m2-assistant bot commented Apr 12, 2019 •

edited by larsroettig

Loading

m2-assistant bot commented Apr 12, 2019 •

edited by larsroettig

Loading

larsroettig commented Apr 12, 2019

larsroettig commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

nickpiro commented Apr 17, 2019

larsroettig commented Apr 18, 2019

celorodovalho commented Apr 23, 2019 •

edited

Loading

hamplr commented Apr 23, 2019

m2-assistant bot commented May 11, 2019

mallikaverma commented May 11, 2019

mallikaverma commented May 11, 2019

mallikaverma commented May 12, 2019

joekersh commented May 13, 2019 •

edited

Loading

larsroettig commented May 13, 2019 •

edited

Loading

m2-assistant bot commented May 27, 2019 •

edited by dmytro-ch

Loading

magento-engcom-team commented May 27, 2019

reense commented Jun 14, 2019

VladimirZaets commented Jan 17, 2020

[Grouped product] Can´t add simple products to cart if one other is out of stock #22304

[Grouped product] Can´t add simple products to cart if one other is out of stock #22304

Comments

hamplr commented Apr 12, 2019 • edited by larsroettig Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented Apr 12, 2019 • edited by larsroettig Loading

m2-assistant bot commented Apr 12, 2019 • edited by larsroettig Loading

larsroettig commented Apr 12, 2019

larsroettig commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

magento-engcom-team commented Apr 12, 2019

nickpiro commented Apr 17, 2019

larsroettig commented Apr 18, 2019

celorodovalho commented Apr 23, 2019 • edited Loading

hamplr commented Apr 23, 2019

m2-assistant bot commented May 11, 2019

mallikaverma commented May 11, 2019

mallikaverma commented May 11, 2019

mallikaverma commented May 12, 2019

joekersh commented May 13, 2019 • edited Loading

larsroettig commented May 13, 2019 • edited Loading

m2-assistant bot commented May 27, 2019 • edited by dmytro-ch Loading

magento-engcom-team commented May 27, 2019

reense commented Jun 14, 2019

VladimirZaets commented Jan 17, 2020

hamplr commented Apr 12, 2019 •

edited by larsroettig

Loading

m2-assistant bot commented Apr 12, 2019 •

edited by larsroettig

Loading

m2-assistant bot commented Apr 12, 2019 •

edited by larsroettig

Loading

celorodovalho commented Apr 23, 2019 •

edited

Loading

joekersh commented May 13, 2019 •

edited

Loading

larsroettig commented May 13, 2019 •

edited

Loading

m2-assistant bot commented May 27, 2019 •

edited by dmytro-ch

Loading