Reset Password Confirmation Link Email Not Store Scoped For Global Customers

[floorz]

Preconditions (*)

1. 2.2.4
2. 2.2.5
3. 2.2.6
4. 2.2.7
5. 2.2.8
6. 2.3.0
7. 2.3.1

Steps to reproduce (*)

1. Setup multi-store site with at least 2 websites
2. Configure customer accounts to be shared globally from admin
3. Create a customer account associated to the second website
4. Initiate reset password email via rest api at PUT /V1/customers/password
   Payload:

{
	"email": "user@example.com",
	"template": "email_reset"
}

5. Receive reset password email from the default store, not the second store

Expected result (*)

1. Receive email from the store the customer is assigned to

Actual result (*)

1. Received email from the initial default store and not the store the customer is assigned to

Use Case Information

We have a client on Magento Cloud with separate websites setup for each region/language (US, Canada, United Kingdom, Spain, China, Japan, etc.). They have mobile apps that will allow customers to register, sign in, register products (custom), and initiate reset password. We needed separate websites to support different base currencies per website.

The mobile apps don't know which website url to use until a customer authenticates which caused a chicken/egg situation with authentication/account creation. We made customer accounts global so the mobile apps can hit the default website url for authentication and be scoped based on the customer's token/assigned store.

The reset password endpoint appears to ignore the customer's store and use the store derived from the website url scoping.

Investigation

In a couple of other methods in the same \Magento\Customer\Model\EmailNotification class, the customer's assigned store id is used instead of the store derived from website domain/url scoping:

https://github.com/magento/magento2/blob/2.3.1/app/code/Magento/Customer/Model/EmailNotification.php#L169-L172
https://github.com/magento/magento2/blob/2.3.1/app/code/Magento/Customer/Model/EmailNotification.php#L195-L198
https://github.com/magento/magento2/blob/2.3.1/app/code/Magento/Customer/Model/EmailNotification.php#L220-L223
https://github.com/magento/magento2/blob/2.3.1/app/code/Magento/Customer/Model/EmailNotification.php#L319-L322

This seems to be the only method not using customer's store id, and the one causing this issue:
https://github.com/magento/magento2/blob/2.3.1/app/code/Magento/Customer/Model/EmailNotification.php#L343-L346

I'm sort of confused about which approach is the correct approach on a broader level, relying on the website domain/url for determining website scope, or the data passed in being website aware like in the case of the customer.

[m2-assistant]

Hi @floorz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@floorz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[floorz]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @floorz. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @floorz, here is your Magento instance.
Admin access: https://i-23295-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[floorz]

Could not reproduce on the vanilla instance provided as emails don't seem to send from there. Did reproduce locally.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[syed92hasan]

I am working on this at #MM19UK

[magento-engcom-team]

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-17601, MC-17602 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.