msrp module error breaks the swatches on product configuration page

[drabikowy]

Preconditions (*)

1. Magento 2.3.1 Theme Luma
2. Msrp module is disabled

Steps to reproduce (*)

1. Add a configurable product
2. Create a configurations for product:

• add two new attributes: color swatch + text swatch
• add separate pictures eg. for color variants
• apply same price to all skus
• apply same quantity to all skus

3. Go to created product's pdp, select color swatch + text swatch and add it to cart
4. Open minicart and click "edit" button to go to product configuration page

Expected result (*)

1. Previously selected configuration should be saved and swatches should be selected
2. Click on the swatch should change the product image (if configured)

Actual result (*)

In console there is an msrp module error which breaks the swatches functionallity:

• preselection of previously selected configuration does not work
• if you configured swatches to change product gallery - this stops working, too

Here is the error that appears:

https://d2aztkdj0ezvrk.cloudfront.net/items/2X3y2T3r163y0i232k16/Image%202019-07-23%20at%2010.00.31%20AM.png

And form my investigation, error is triggered in swatches-renderer.js OnClick method, where below logic triggers the "updateMsrpPriceBlock" event:

$(document).trigger('updateMsrpPriceBlock',
    [
        parseInt($this.attr('index'), 10) + 1,
        $widget.options.jsonConfig.optionPrices
]);

On regular PDP, msrp module does not listen to this event, while on product configuration page it does - even if msrp is disabled. Either msrt should not listen here, too or wrong data is passed to this event and it breaks.

[m2-assistant]

Hi @drabikowy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@drabikowy do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[drabikowy]

@magento give me 2.3-develop instance - upcoming 2.3.x release

[magento-engcom-team]

Hi @drabikowy. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @drabikowy, here is your Magento instance.
Admin access: https://i-23832-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[drabikowy]

I confirm - issue is reproducible on provided Magento instance.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[drabikowy]

Hello! Actually it was disabled by default on provided instance. I mean in stores->configuration->sales->minimum advertised price - I didn’t touch this settings W dniu wt., 23.07.2019 o 13:10 Robert Turchyn <notifications@github.com> napisał(a):

…

Hi, @drabikowy <https://github.com/drabikowy> ! How did you disable the Msrp module? Because when i turned it off my magento stopped working: [image: wowowo] <https://user-images.githubusercontent.com/51680850/61707469-3aafc780-ad53-11e9-82b2-b5e6d3aeef16.png> Frontent doesn't work either. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23832?email_source=notifications&email_token=AFKUNBLMDMQPPSVFLFJPRQLQA3RK3A5CNFSM4IGBQRK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2SYP5Y#issuecomment-514164727>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFKUNBOCHKC5QPLMC4X3YCLQA3RK3ANCNFSM4IGBQRKQ> .