Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When category URL page param is larger than the pagination, the page will break with elastic search 2 #23843

Closed
ron-jomashop opened this issue Jul 23, 2019 · 10 comments · Fixed by #31594
Assignees
Labels
Component: Elasticsearch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@ron-jomashop
Copy link

ron-jomashop commented Jul 23, 2019

Preconditions (*)

  1. Magento 2.3.2
  2. Elasticsearch 2

Steps to reproduce (*)

  1. Create a category with products
  2. Enable elasticsearch 2
  3. Reindex all
  4. Go to the category and add this params: "?p=999999999999999&product*list_order=price". Ex: https://www.example.com/category?p=9999999999999999999999999999&product_list*order=price

Expected result (*)

  1. Go to the last page of the category

Actual result (*)

  1. {{1 exception(s):
    Exception #0 (Elasticsearch\Common\Exceptions\ServerErrorResponseException): {"error":{"rootcause":<{"type":"json_parse_exception","reason":"Numeric value (2.3058430092137e20) out of range of int (-2147483648 - 2147483647)\n at [Source: [B@33145eaa; line: 1, column: 28]"}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":"magento2_product_1_v173","node":"viwpe1vCTrGQomOe0uHakA","reason":{"type":"json_parseexception","reason":"Numeric value (2.3058430092137e20) out of range of int (-2147483648 - 2147483647)\n at [Source: [B@33145eaa; line: 1, column: 28]"}}>},"status":500}}}
@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2019

Hi @ron-jomashop. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ron-jomashop do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 23, 2019
@ron-jomashop
Copy link
Author

I cannot test with the Magento instance because this ticket related to the elasticsearch.

@engcom-Charlie engcom-Charlie self-assigned this Jul 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 24, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Charlie engcom-Charlie added Component: Elasticsearch Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Jul 24, 2019
@engcom-Charlie
Copy link
Contributor

Hi, @ron-jomashop ! I'm sorry, but i have to close this issue, because i can't reproduce it on 2.3-develop and 2.3.2 branches(have not any exception after adding this params: "?p=999999999999999&product_list_order=price").
Thank for contributing!

@ron-jomashop
Copy link
Author

ron-jomashop commented Jul 24, 2019

@engcom-Charlie
Please have a look again. I have tested with Magento repo with Magento sample data and it also has the error.
The page you need to go to is http://127.0.0.1/training/training-video.html?p=999999999999999
and it should produce the error with the Elasticsearch 2 enabled.

@engcom-Charlie
Copy link
Contributor

@ron-jomashop , that is right! I'm sorry about closing this issue.
Thank you for contributing!

@ghost ghost unassigned engcom-Charlie Jul 24, 2019
@engcom-Charlie engcom-Charlie self-assigned this Jul 24, 2019
@engcom-Charlie engcom-Charlie added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Jul 24, 2019
@ghost ghost unassigned engcom-Charlie Jul 24, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-18549 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 24, 2019
@edenduong edenduong self-assigned this Jul 25, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2019

Hi @edenduong. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Elasticsearch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Archived in project
7 participants