[Magento 2.3.2] Upload fails in image uploader

[posttechguy]

Preconditions:
Magento 2.4-develop
Php 7.3
fileinfo php extension is disabled

Steps to reproduce:

1. Go to Admin -> Content -> Pages;
2. Open "Home Page" to edit (for ex.);
3. Expand the Content tab;
4. Select the image uploader ("Insert Image" button or the one in the editor);
5. Select an image from your HD and upload it.

Actual Result: ✖️ Error: Call to undefined function mime_content_type()

✖️ An error is shown: "File validation failed." No image is uploaded.

Expected Result: ✔️ An image must be uploaded without errors

The temp uploaded file, i.e., '/tmp/sdfds5we23e', which has no extension, is trying to get the extension thus failing to verify against the validTypes array

[m2-assistant]

Hi @posttechguy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@posttechguy do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Charlie]

Hello @posttechguy thank you for your report! I'm not able to reproduce issue on clean Magento 2.3.2 .

Manual testing scenario:

1. Go to Content -> Pages -> Edit Home page
2. Add img to Content of CMS Page
   

Actual result:
Image uploaded without any errors

So i have to close this issue. If you have more info please update your issue.

[posttechguy]

Hi @engcom-Charlie I can confirm that the file upload does not work on 2.3-develop. The reason is that the mime_content_type is removed in 7.1, and while it is checked to see if it exists the getFileExtension is not retrieving the ext because when the file is uploaded to /tmp directory, it saves it without an extension. So there is now way to ascertain whether the file is valid or not.

I have tried it on PHP 7.2.16 also

Bevan

[posttechguy]

I have also found this bug, on PHP 7.2.16

Fatal error: Uncaught Error: Call to undefined function mime_content_type() in /vagrant/httpdocs/m23-dev/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php:362 Stack trace: #0 /vagrant/httpdocs/m23-dev/app/code/Magento/Cms/Block/Adminhtml/Wysiwyg/Images/Content/Files.php(60): Magento\Cms\Model\Wysiwyg\Images\Storage->getFilesCollection('/vagrant/httpdo...', 'image') #1 /vagrant/httpdocs/m23-dev/app/code/Magento/Cms/Block/Adminhtml/Wysiwyg/Images/Content/Files.php(74): Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content\Files->getFiles() #2 /vagrant/httpdocs/m23-dev/app/code/Magento/Cms/view/adminhtml/templates/browser/content/files.phtml(13): Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content\Files->getFilesCount() #3 /vagrant/httpdocs/m23-dev/lib/internal/Magento/Framework/View/TemplateEngine/Php.php(59): include('/vagrant/httpdo...') #4 /vagrant/httpdocs/m23-dev/lib/internal/Magento/Framework/View/Element/Template.php(270): Magento\Framework\View\TemplateEngine\Php->render(Object(Magento\Cms\Block\Adminhtml\Wysiwyg\Im in /vagrant/httpdocs/m23-dev/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php on line 362

Again calling the removed function mime_content_type

[engcom-Charlie]

@posttechguy sorry but in my Magento 2.3.2 instance all works fine:

[hostep]

This is a duplicate of #16531 (comment)

@posttechguy: installing the fileinfo php extension should solve your issue.

In my opinion the fileinfo extension needs to get added to the requirements in the composer.json file of Magento's Framework and the composer.json file of the CMS module

Interested in creating a pull request for this?

[posttechguy]

Thanks @hostep, that was my issue.

I have added a PR for the issue

Cheers

[AndyJAllen]

Adding the fileinfo extension fixed my issue too. This should be added to the requirements page:
https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-21825 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[krisdante]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @krisdante. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @krisdante, here is your Magento instance.
Admin access: https://i-24332-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-37754 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[magento-engcom-team]

Hi @posttechguy. Thank you for your report.
The issue has been fixed in #29671 by @konarshankar07 in 2.4-develop branch
Related commit(s):

• 8344b1193b33ec89457b3717362dd923f4a7c97d
• 8da5e70859784f0cf097fae1bcbaa240db55fb85
• d312ab5f63f22329c3dde98cbcebb2347c8f077c
• f7503ea597d79ed29b544daf169c7ced14ba42f9
• c09a26144f24548271e908efb4232baec079b92a
• 12098680bbfa555b8aad268bf8156ada710d507b
• 60c01638fe0f00d92184308eba1599cd58a74f6f
• 21f1eb357ce85f236f9af06ba3e429643ad28e3c
• 0cf0e09cf5453c7fb4f8502722b1a0447c00b9db
• 09bd902440a57c2253f8f44abbbe1da8e98901fc

The fix will be available with the upcoming 2.4.2 release.