Price Indexer Performance Issue With Out of Stock Products

[brucemead]

Preconditions (*)

Magento 2.x

Steps to reproduce (*)

1. Ensure that display out of stock products option is disabled
2. php bin/magento indexer:reindex catalog_product_price
3. php bin/magento cron:run --group=index

You'll see because of the lack of a where using $entityIds in https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/CatalogInventory/Model/Indexer/ProductPriceIndexFilter.php#L87 its executing a the delete for every product every time this method is called.

Expected result (*)

To only delete products which are not in stock filtered by $entityIds supplied.

Actual result (*)

Deletes every product which are not in stock as not where filter implimented.

[m2-assistant]

Hi @brucemead. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@brucemead do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[brucemead]

I've created a PR to resolve this issue #24415