Skip to content

Added unique key on eav_attribute_option_value table #24720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Added unique key on eav_attribute_option_value table #24720

merged 1 commit into from
Oct 3, 2019

Conversation

UncleTioma
Copy link
Contributor

@UncleTioma UncleTioma commented Sep 25, 2019 •
edited
Loading

Description (*)

Added unique key on eav_attribute_option_value table

Fixed Issues (if relevant)

  1. Missing unique key on eav_attribute_option_value table #24718: MIssing unique key on eav_attribute_option_value table

Manual testing scenarios (*)

  1. Installed fresh magento2.3-develop and the unique key was missing
  2. After added the unique key to table reinstall Magento and its fixed.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@UncleTioma UncleTioma requested a review from akaplya as a code owner September 25, 2019 09:32
@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2019

Hi @UncleTioma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@orlangur orlangur self-assigned this Sep 25, 2019
orlangur
orlangur requested changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash changes into a single commit so that we have perfectly clean history 😉

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5956 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@UncleTioma UncleTioma force-pushed the feature/t24718_unique_key_eav_attribute_option_value_table branch from 9dd4257 to 502146f Compare September 27, 2019 08:35
@UncleTioma UncleTioma requested a review from orlangur September 27, 2019 10:19
@ghost ghost assigned sidolov Sep 30, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5956 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 2, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 2, 2019
@ghost ghost added the Progress: accept label Oct 2, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Oct 3, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 3, 2019
@sidolov
ENGCOM-5956: Added unique key on eav_attribute_option_value table #24720
3b217e7
@magento-engcom-team magento-engcom-team merged commit 502146f into magento:2.3-develop Oct 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @UncleTioma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 3, 2019
@ihor-sviziev ihor-sviziev linked an issue Jun 18, 2020 that may be closed by this pull request
Missing unique key on eav_attribute_option_value table #24718
Closed
@ihor-sviziev ihor-sviziev mentioned this pull request Jun 18, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@akaplya akaplya Awaiting requested review from akaplya

@orlangur orlangur Awaiting requested review from orlangur

Assignees

@orlangur orlangur

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Eav Partner: Elogic partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.

Missing unique key on eav_attribute_option_value table
6 participants
@UncleTioma @magento-engcom-team @engcom-Alfa @orlangur @sidolov @engcom-Golf