Add unique key on eav_attribute_option_value table #28796

ihor-sviziev · 2020-06-18T10:52:25Z

This PR re-adds changes from #24720 after they were reverted due to missing approval for backward incompatible changes.

Description (*)

I believe we SHOULD add this index even if it's backward incompatible change as duplicated data in this table causing a lot of issues, we're having report page when trying to load attribute option values, explanation is here:
#24718 (comment)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Missing unique key on eav_attribute_option_value table #24718

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-06-18T10:52:29Z

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

(cherry picked from commit 502146f)

ihor-sviziev · 2020-06-18T11:03:17Z

@magento run all tests

engcom-Delta · 2020-07-27T11:09:12Z

✔️ QA passed
Before:
❌ Error is shown when retrieving duplicate values of attribute options

After:
✔️ No possibility to set duplicate values for attribute options

✔️ Was checked saving attribute option values for different store views works as before

Pull Request state was updated. Re-review required.

engcom-Charlie · 2020-07-28T07:11:09Z

Semantic Version Checker failed because of Unique key was added. It needs to approve.

ihor-sviziev · 2020-09-16T07:40:01Z

Seems like this is big change, we need to accept it in 2.5 release line

gabrieldagama · 2020-10-07T10:38:38Z

Approval ticket - https://jira.corp.magento.com/browse/MC-37068

engcom-Charlie · 2023-09-06T08:02:00Z

We have got the approval for our approval JIRA for Semantic Version Checker failure.

Moving it to back to Ready for testing to get the latest code merge and get the QA done again.

Thank you!

…-value

engcom-Lima · 2023-09-13T05:42:04Z

@magento run all tests

magento-automated-testing · 2023-09-13T05:42:12Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

…-value

engcom-Lima · 2023-09-14T06:44:40Z

@magento run all tests

magento-automated-testing · 2023-09-14T06:44:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Lima · 2023-09-14T08:49:36Z

@magento run Functional Tests B2B , Functional Tests CE

magento-automated-testing · 2023-09-14T08:49:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Lima · 2023-09-14T09:29:32Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

Verify in the eav_attribute_option_value table the duplicate value of the option_id

Before: ✖️

Frontend:

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

…-value

engcom-Echo · 2023-12-18T06:56:47Z

@magento run all tests

magento-automated-testing · 2023-12-18T06:56:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-18T08:48:00Z

@magento run WebAPI Tests,Unit Tests,Static Tests,Integration Tests,Functional Tests B2B

magento-automated-testing · 2023-12-18T08:48:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-18T11:19:32Z

@magento run Unit Tests

magento-automated-testing · 2023-12-18T11:19:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-18T11:21:12Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-12-18T11:21:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-18T13:18:42Z

Functional Tests B2B failure are different on last two run on same commit.
Run1

Run2

We have got the approval for our approval JIRA for Semantic Version Checker failure. Hence moving it to merge in progress

ghost added the Progress: pending review label Jun 18, 2020

magento-engcom-team added Component: Eav Release Line: 2.4 labels Jun 18, 2020

ghost added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Jun 18, 2020

Add unique key on eav_attribute_option_value table

eb05a10

(cherry picked from commit 502146f)

ihor-sviziev force-pushed the add-unique-ket-on-eav-attribut-option-value branch from ce15dd0 to eb05a10 Compare June 18, 2020 11:00

davidverholen previously approved these changes Jun 28, 2020

View reviewed changes

ghost assigned davidverholen Jun 28, 2020

ghost added Progress: ready for testing and removed Progress: pending review labels Jun 28, 2020

engcom-Delta self-assigned this Jul 27, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 27, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jul 27, 2020

engcom-Charlie self-assigned this Jul 27, 2020

ghost added Progress: to approve and removed Progress: extended testing labels Jul 28, 2020

ghost added the Priority: P3 May be fixed according to the position in the backlog. label Aug 14, 2020

ihor-sviziev added this to the 2.5 milestone Sep 16, 2020

ihor-sviziev removed this from the 2.5 milestone Nov 9, 2020

m2-community-project bot added Progress: review and removed Progress: to approve labels Nov 9, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: pending approval labels Sep 6, 2023

Merge branch '2.4-develop' into add-unique-ket-on-eav-attribut-option…

c5300aa

…-value

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Sep 13, 2023

Merge branch '2.4-develop' into add-unique-ket-on-eav-attribut-option…

7f9c109

…-value

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Sep 14, 2023

Merge branch '2.4-develop' into add-unique-ket-on-eav-attribut-option…

14ee777

…-value

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 18, 2023

magento-devops-reposync-svc merged commit db49817 into magento:2.4-develop Jul 4, 2024

ihor-sviziev deleted the add-unique-ket-on-eav-attribut-option-value branch October 25, 2024 14:47

Add unique key on eav_attribute_option_value table #28796

Add unique key on eav_attribute_option_value table #28796

Uh oh!

Conversation

ihor-sviziev commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jun 18, 2020

Uh oh!

ihor-sviziev commented Jun 18, 2020

Uh oh!

engcom-Delta commented Jul 27, 2020

Uh oh!

engcom-Charlie commented Jul 28, 2020

Uh oh!

ihor-sviziev commented Sep 16, 2020

Uh oh!

gabrieldagama commented Oct 7, 2020

Uh oh!

engcom-Charlie commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Lima commented Sep 13, 2023

Uh oh!

magento-automated-testing bot commented Sep 13, 2023

Uh oh!

engcom-Lima commented Sep 14, 2023

Uh oh!

magento-automated-testing bot commented Sep 14, 2023

Uh oh!

engcom-Lima commented Sep 14, 2023

Uh oh!

magento-automated-testing bot commented Sep 14, 2023

Uh oh!

engcom-Lima commented Sep 14, 2023

✔️ QA Passed

Uh oh!

engcom-Echo commented Dec 18, 2023

Uh oh!

magento-automated-testing bot commented Dec 18, 2023

Uh oh!

engcom-Echo commented Dec 18, 2023

Uh oh!

magento-automated-testing bot commented Dec 18, 2023

Uh oh!

engcom-Echo commented Dec 18, 2023

Uh oh!

magento-automated-testing bot commented Dec 18, 2023

Uh oh!

engcom-Echo commented Dec 18, 2023

Uh oh!

magento-automated-testing bot commented Dec 18, 2023

Uh oh!

engcom-Echo commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ihor-sviziev commented Jun 18, 2020 •

edited

Loading

engcom-Charlie commented Sep 6, 2023 •

edited

Loading

engcom-Echo commented Dec 18, 2023 •

edited

Loading