Method chaining broken by refactor in Module_Catalog Product Collection

[abdulmueid]

The commit a77fd52 refactors the method addAttributeToFilter in file app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php by adding two new methods addIsSaleableAttributeToFilter and addTierPriceAttributeToFilter.

However, there are missing return statements in the if statement which break method chaining. https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php#L1591-L1597

Preconditions (*)

1. Magento Version 2.3.3

Steps to reproduce (*)

1. Create an instance of \Magento\Catalog\Model\ResourceModel\Product\Collection
2. Call the method addAttributeToFilter with attribute is_saleable
3. Chain the method addAttributeToFilter with any other attribute to chain the function

Expected result (*)

1. Method chaining works as expected

Actual result (*)

1. addAttributeToFilter returns null when adding is_saleable to filter, therefore breaking method chaining

[m2-assistant]

Hi @abdulmueid. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@abdulmueid do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[electroidru]

I think that's critical. After update to 2.3.3 exception with porto theme PHP Fatal error: Uncaught TypeError: Argument 1 passed to Magento\Catalog\Model\ResourceModel\Product\Collection::addIsSaleableAttributeToFilter()

[abdulmueid]

@electroidru that error is a related but separate problem. The new method signatures type check condition parameter for nullable array whereas the calling method addAttributeToFilter does not type check the condition at all.

This breaks a number of popular themes (Porto, Market) and modules which filter products. We can open another issue for this behavior. I'm still debugging and checking for all the misbehaviours.

[m2-assistant]

Hi @maheshWebkul721. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[mahesh-rajawat]

@shikhamis11 Please look in to this, and confirm this issue. This issue is reproducible.

[m2-assistant]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[shikhamis11]

Hello @abdulmueid
thank you for reporting this issue

The commit a77fd52 refactors the method addAttributeToFilter in file app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php by adding two new methods addIsSaleableAttributeToFilter and addTierPriceAttributeToFilter.
However, there are missing return statements in the if statement which break method chaining.

yes you are right Please make Pull request with it's solution
you can check guide for contribution
https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html