Category image deletes after initial upload and category save v2.3.3

[davygxyz]

Triage Note

• The issue is reproducible on 2.3.3 release version
• The issue is NOT reproducible on 2.3-develop
• 2.3.3 is not merged into 2.3-develop at this moment

Preconditions (*)

1. Magento Version 2.3.3
2. PHP version 7.2
3. Apache 2.4
4. Magento Default Theme

Steps to reproduce (*)

1. Installed with composer: composer create-project --repository=https://repo.magento.com/ magento/project-community-edition
2. Installed and logged into the admin
3. Click on catalog > categories
4. Upload category image
5. Save category
6. Save category again

Expected result (*)

1. After the initial category image upload and save, if you save the category again without changing the image. The category should retain the original category image.

Actual result (*)

1. Instead, after my initial category image upload and save. The image disappears if I save the category.

[m2-assistant]

Hi @davygxyz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@davygxyz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[davygxyz]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @davygxyz. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @davygxyz, here is your Magento instance.
Admin access: https://i-25099-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[bliswebagency]

We also have this problem after upgrading to 2.3.3. In our case the initial upload via ajax will suffix the file name with a _1, then on the subsequent saves, within the system it will try to match a filename with suffix _1_1 or a _2, _2_1 and so on, which seems to disassociate the file from the category. This only happens for the category section and not products.

Some relevant functions identified were getNewFileName (framework/File/Uploader.php) which suffixes a number to the filename, and checkUniqueImageName (module-catalog/Model/Category/Attribute/Backend/Image.php) which is triggered by the beforeSave event for categories. But it may be further up the callstack where the problem starts.