Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when trying to unset additional data in payment method. #26083

Closed
marcoaacoliveira opened this issue Dec 17, 2019 · 3 comments
Closed
Assignees
Labels
Component: Payment Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@marcoaacoliveira
Copy link
Member

marcoaacoliveira commented Dec 17, 2019

Preconditions (*)

  1. Magento 2.3.2 & PHP 7.2.21

Steps to reproduce (*)

  1. You must use \Magento\Payment\Model\Info::setAdditionalInformation to add an additional information to a payment method;
  2. Try to use \Magento\Payment\Model\Info::unsAdditionalInformation to remove the inserted additional data.

Expected result (*)

  1. \Magento\Payment\Model\Info::unsAdditionalInformation should remove an additional information from table quote_payment column additional_information after save the quote.

Actual result (*)

  1. \Magento\Payment\Model\Info::unsAdditionalInformation didn't remove the data in additional_information (column)
@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2019

Hi @marcoaacoliveira. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@marcoaacoliveira do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 17, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2019

Hi @marcoaacoliveira. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


marcoaacoliveira added a commit to marcoaacoliveira/magento2 that referenced this issue Dec 17, 2019
@sudheers-kensium sudheers-kensium added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 18, 2019
@VladimirZaets
Copy link
Contributor

Hi @marcoaacoliveira. Thank you for your report.
The issue has been fixed in #26084 by @marcoaacoliveira in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 3, 2020
magento-engcom-team added a commit that referenced this issue Jan 3, 2020
…agento\Payment\Model\Info #26084

 - Merge Pull Request #26084 from marcoaacoliveira/magento2:2.4-develop
 - Merged commits:
   1. 13f34cd
   2. 32227d2
   3. 77390c1
   4. ad1059f
   5. 408b725
magento-engcom-team pushed a commit that referenced this issue Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Payment Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

5 participants