Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL : CORS requests will fail without OPTIONS reponse #28561

Closed
magento-engcom-team opened this issue Jun 5, 2020 · 8 comments · Fixed by #28713
Closed

GraphQL : CORS requests will fail without OPTIONS reponse #28561

magento-engcom-team opened this issue Jun 5, 2020 · 8 comments · Fixed by #28713
Assignees
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Project: GraphQL Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Milestone

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 5, 2020

As a web developer, I want Magento to support the CORS standard so that I can develop my applications according to defined best practices.


Original issue: #8399

AC

@magento-engcom-team magento-engcom-team added Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for Dev in Community Backlog Jun 5, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@nrkapoor nrkapoor moved this from Ready for Dev to Good First Issue in Community Backlog Jun 5, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 5, 2020
@michalderlatka michalderlatka self-assigned this Jun 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 7, 2020

Hi @michalderlatka. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost moved this from Good First Issue to Dev in Progress in Community Backlog Jun 7, 2020
@michalderlatka
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor Author

Hi @michalderlatka. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor Author

Hi @michalderlatka, here is your Magento instance.
Admin access: https://i-28561-2-4-develop.instances.magento-community.engineering/admin_2038
Login: fc88d7e7 Password: 1f98a19bfffd
Instance will be terminated in up to 3 hours.

@michalderlatka
Copy link
Contributor

@nrkapoor do you want CORS headers to be fully configurable from admin panel, so administrator will be able to specify which domains are allowed to make CORS request? or just add wildcard *?

@nrkapoor
Copy link

nrkapoor commented Jun 8, 2020

@michalderlatka We want it configurable via the admin panel. + @maghamed Can you confirm?

@ghost ghost moved this from Dev in Progress to Ready for Dev in Community Backlog Jun 9, 2020
@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 9, 2020
@ghost ghost removed the Progress: ready for dev label Jun 9, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jun 12, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jun 18, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jun 22, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jun 23, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jun 23, 2020
@cpartica
Copy link
Contributor

@michalderlatka can you correct that URL for " CORS standard " ? it doesn't really work

@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jun 25, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 27, 2020
@magento-engcom-team magento-engcom-team added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 9, 2020
@magento-engcom-team magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done labels Jul 20, 2020
@magento-engcom-team magento-engcom-team added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Progress: done and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Progress: ready for dev labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Project: GraphQL Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

Successfully merging a pull request may close this issue.

4 participants