-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Component: CheckoutComponent: TranslationIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Affects non-critical data or functionality and does not force users to employ a workaround.
Description
This issue is automatically created based on existing pull request: #28547: 'Ship Here' in CamelCase as that's how it is written elsewhere
Preconditions (*)
In the checkout shipping address modal the text in the primary button was written with a lowercase 'h'. On all other places, and in the translation files, it is written with a capital: 'Ship Here'. As a result, the button with the lowercase version 'Ship here' isn't translated.
- Has a simple product;
- Logged as Customer to Storefront with at least 1 saved address;
Steps to reproduce:
- Add translation for "Ship Here" in translation file; ("Ship Here","Ship Here (translated)" for ex.);
- Add product to Cart;
- Click on "Proceed to Checkout" button;
- Click on "+ New Address" button;
Actual Result: ✖️ The phrase was not translated
Expected Result: ✔️ The phrase was successfully translated
Questions or comments
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Component: CheckoutComponent: TranslationIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Affects non-critical data or functionality and does not force users to employ a workaround.