Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] 'Ship Here' in CamelCase as that's how it is written elsewhere #28685

Closed
4 tasks
m2-assistant bot opened this issue Jun 11, 2020 · 3 comments · Fixed by #28547
Closed
4 tasks

[Issue] 'Ship Here' in CamelCase as that's how it is written elsewhere #28685

m2-assistant bot opened this issue Jun 11, 2020 · 3 comments · Fixed by #28547
Labels
Component: Checkout Component: Translation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2020

This issue is automatically created based on existing pull request: #28547: 'Ship Here' in CamelCase as that's how it is written elsewhere


Preconditions (*)

In the checkout shipping address modal the text in the primary button was written with a lowercase 'h'. On all other places, and in the translation files, it is written with a capital: 'Ship Here'. As a result, the button with the lowercase version 'Ship here' isn't translated.

  1. Has a simple product;
  2. Logged as Customer to Storefront with at least 1 saved address;

Steps to reproduce:

  1. Add translation for "Ship Here" in translation file; ("Ship Here","Ship Here (translated)" for ex.);
  2. Add product to Cart;
  3. Click on "Proceed to Checkout" button;
  4. Click on "+ New Address" button;

Actual Result: ✖️ The phrase was not translated

screenshot_47

Expected Result: ✔️ The phrase was successfully translated

screenshot_48

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Checkout Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 11, 2020
@ghost ghost added this to Ready for QA in Community Backlog Jun 11, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jun 11, 2020
@engcom-Alfa engcom-Alfa self-assigned this Jun 11, 2020
@m2-assistant
Copy link
Author

m2-assistant bot commented Jun 11, 2020

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added Component: Translation Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 11, 2020
@ghost ghost unassigned engcom-Alfa Jun 11, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Jun 11, 2020
@ghost ghost removed the Progress: ready for QA label Jun 11, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-35113 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 11, 2020
@engcom-Alfa
Copy link
Contributor

The issue has been fixed in #28547 by @woutk88 in 2.4-develop branch

@ghost ghost moved this from Ready for Dev to Done (last 30 days) in Community Backlog Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Component: Translation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

Successfully merging a pull request may close this issue.

2 participants