Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQl. Mutation: customerOrders query and gift_message attribute #28957

Closed
5 tasks
atwixfirster opened this issue Jul 1, 2020 · 8 comments · Fixed by #28958
Closed
5 tasks

GraphQl. Mutation: customerOrders query and gift_message attribute #28957

atwixfirster opened this issue Jul 1, 2020 · 8 comments · Fixed by #28958
Assignees
Labels
Area: APIs Component: GiftMessageGraphQl Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone

Comments

@atwixfirster
Copy link
Contributor

atwixfirster commented Jul 1, 2020

Preconditions (*)

Error Can't load gift message for order is returned when order does not have a gift_message:

001

Steps to reproduce (*)

  1. Magento (2.4-develop) with a sample data
  2. Generate customer token:
mutation {
  generateCustomerToken(
    email: "roni_cost@example.com"
    password: "roni_cost3@example.com"
  ) {
    token
  }
}
  1. Retrieve customer orders:
query {
    customerOrders {
        items {
            order_number
            gift_message {
                to
                from
                message
            }
        }
    }
}

Expected result (*)

We do not need to have a Can't load gift message for order error in the response when an order does not have gift_message.

Actual result (*)

There is a Can't load gift message for order error in the response when an order does not have gift_message.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2020

Hi @atwixfirster. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for QA in Community Backlog Jul 1, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 1, 2020
@ghost ghost assigned atwixfirster Jul 1, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Jul 1, 2020
@dmytro-ch dmytro-ch self-assigned this Jul 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 3, 2020

Hi @dmytro-ch. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jul 3, 2020
@dmytro-ch dmytro-ch added Component: GiftMessageGraphQl Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jul 3, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 3, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @dmytro-ch
Thank you for verifying the issue. Based on the provided information internal tickets MC-35620 were created

Issue Available: @dmytro-ch, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Priority: P3 May be fixed according to the position in the backlog. label Aug 15, 2020
@nrkapoor nrkapoor moved this from PR In Progress to Ready for Dev in Community Backlog Sep 19, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Sep 24, 2020
@ghost ghost removed this from Ready for Dev in Community Backlog Oct 20, 2020
@ghost ghost removed this from Pull Request In Progress in Low Priority Backlog Oct 20, 2020
@nrkapoor nrkapoor added this to the 2.4.3 milestone Dec 20, 2020
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Dec 20, 2020
@mauragcyrus
Copy link

@magento export issue to Jira project MCLOUD as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/MCLOUD-7746) is successfully created for this issue.

@sdzhepa sdzhepa removed this from Pull Request In Progress in GraphQL Backlog Nov 8, 2021
@sdzhepa sdzhepa added this to Pull Request In Progress in Low Priority Backlog Nov 8, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Apr 8, 2022
@cpartica cpartica added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Priority: P3 May be fixed according to the position in the backlog. labels Apr 8, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Apr 8, 2022
@m2-community-project m2-community-project bot removed this from Ready for Development in Low Priority Backlog Apr 8, 2022
@sidolov sidolov added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 21, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Apr 21, 2022
@sidolov sidolov added Area: APIs Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 21, 2022
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-2794

@engcom-Hotel
Copy link
Contributor

Hello @atwixfirster,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-2794 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-2794&type=commits

Based on Jira, the target version is 2.4.5.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: APIs Component: GiftMessageGraphQl Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
9 participants