Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery inside magnifier moves blocky #29076

Closed
1 of 5 tasks
GrimLink opened this issue Jul 10, 2020 · 4 comments · Fixed by #29077
Closed
1 of 5 tasks

Gallery inside magnifier moves blocky #29076

GrimLink opened this issue Jul 10, 2020 · 4 comments · Fixed by #29077
Assignees
Labels
Area: Lib/Frontend Component: Image Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@GrimLink
Copy link
Member

GrimLink commented Jul 10, 2020

Preconditions (*)

The magnifier moves only when the cursor is leaving the magnifier area.
Causing a blocky movement.
This behavior only happens to the magnifier when the mode option is set to inside.

Tested on a clean Magento 2.3.5 version.

Steps to reproduce (*)

In the view.xml for any theme.
Enable the magnifier and set the mode to inside.

<var name="magnifier">
  <var name="enabled">true</var> <!-- Turn on/off magnifier (true/false) -->
  <var name="mode">inside</var> <!-- Zoom type (outside/inside) -->
</var>

Expected result (*)

A smooth movement.
Where the magnifier moves with the mouse cursor.

Screen Recording 2020-07-10 at 22 15 23

Actual result (*)

Blocky movement as seen on this image.

Screen Recording 2020-07-10 at 22 18 18


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2020

Hi @GrimLink. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 10, 2020
@ghost ghost added this to Ready for QA in Community Backlog Jul 10, 2020
@ghost ghost assigned GrimLink Jul 10, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Jul 10, 2020
@ghost ghost added Progress: PR in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: ready for QA labels Jul 10, 2020
@engcom-Alfa engcom-Alfa added Area: Lib/Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 16, 2020
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jul 16, 2020
@magento-engcom-team
Copy link
Contributor

@engcom-Alfa Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@ghost ghost moved this from PR In Progress to Ready for QA in Community Backlog Jul 16, 2020
@engcom-Alfa engcom-Alfa added Component: Image Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: ready for QA labels Jul 16, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Jul 16, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-35918 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 16, 2020
@VladimirZaets VladimirZaets added the Priority: P3 May be fixed according to the position in the backlog. label Jul 16, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Jul 16, 2020
@sdzhepa sdzhepa added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label Jul 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @GrimLink. Thank you for your report.
The issue has been fixed in #29077 by @GrimLink in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jul 23, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jul 23, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.5 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Component: Image Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Development

Successfully merging a pull request may close this issue.

5 participants