-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Component: OtherFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P4No current plan to fix. Fixing can be deferred as a logical part of more important work.No current plan to fix. Fixing can be deferred as a logical part of more important work.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.Affects aesthetics, professional look and feel, “quality” or “usability”.Triage: DoneHas been reviewed and prioritized during Triage with Product ManagersHas been reviewed and prioritized during Triage with Product Managers
Description
This issue is automatically created based on existing pull request: #28975: improve NonComposerComponentRegistration
Description (*)
Magento 2.4-develop
enable strict mode and added typeHint, this changes make execution of code more secure.
remove useless assignation $main
.
Expected behavior (*)
Benefits
Additional information
Manual testing scenarios not necessary, if CI passes this code is good, it's only technical improvement.
Metadata
Metadata
Assignees
Labels
Component: OtherFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P4No current plan to fix. Fixing can be deferred as a logical part of more important work.No current plan to fix. Fixing can be deferred as a logical part of more important work.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.Affects aesthetics, professional look and feel, “quality” or “usability”.Triage: DoneHas been reviewed and prioritized during Triage with Product ManagersHas been reviewed and prioritized during Triage with Product Managers
Type
Projects
Status
Done