Hardcoded path causes collisions

[miguelbalparda]

magento2/app/code/Magento/Analytics/Model/ExportDataHandler.php

Line 25 in 9544fb2

private $subdirectoryPath = 'analytics/';

This hardcoded path will cause issues when more than 1 Magento install is using the same server. It might be useful to make it unique per install, maybe using the domain URL or another unique value.

Preconditions (*)

1. Magento Analytics installed
2. More than one Magento instance on the same server

Steps to reproduce (*)

1. Found static path $subdirectoryPath = 'analytics/'; in dir magento2/app/code/Magento/Analytics/Model/ExportDataHandler.php
2. We used Magento 1st instance and made some minor code changes as per Hardcoded path causes collisions #29373 (comment) in CollectData.php and ExportDataHandler.php respectively to print the dir /private/tmp/analytics/tmp/.
3. We used Magento 2nd instance and made same code changes in CollectData.php and ExportDataHandler.php respectively to print the dir /private/tmp/analytics/tmp/.

Issue: Both Magento instances are inserting the analytics data to the same path.

Expected result (*)

1. Different Magento 2 installs will use different paths

Actual result (*)

1. Different Magento 2 installs will use the same paths

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @miguelbalparda. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

[hostep]

Issue totally makes sense. So if I understand it correctly multiple Magento installations on the same (linux) server will all write to /tmp/analytics/ which might mix up data for all these shops together and send them over to Magento Analytics service, which can lead to very incorrect data and can probably even be seen as a security issue...

@sidolov: can somebody verify and then assign priorities?

Might be relevant:

• magento2/lib/internal/Magento/Framework/Filesystem/DirectoryList.php

  Line 100 in 427f9bf

  $sysTmpPath = get_cfg_var('upload_tmp_dir') ?: sys_get_temp_dir();

• https://www.php.net/manual/en/function.sys-get-temp-dir.php#121073

[sidolov]

@hostep yes, we will verify all the not confirmed tickets marked as stale before the due date. Thank you for the input!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[hostep]

This stalebot is getting a bit annoying...