Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Late Static Binding on private constants in Magento\Catalog\ViewModel\Product\Breadcrumbs #29879

Closed
1 of 5 tasks
Cheeerd opened this issue Sep 3, 2020 · 5 comments · Fixed by #29925
Closed
1 of 5 tasks

Late Static Binding on private constants in Magento\Catalog\ViewModel\Product\Breadcrumbs #29879

Cheeerd opened this issue Sep 3, 2020 · 5 comments · Fixed by #29925
Assignees
@toxix
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog

Comments

@Cheeerd
Copy link

Cheeerd commented Sep 3, 2020

Preconditions (*)

  1. Magento 2.4.0
  2. PHP 7.4.9

Steps to reproduce (*)

  1. Create a plugin for Magento\Catalog\ViewModel\Product\Breadcrumbs

Expected result (*)

  1. All works

Actual result (*)

  1. Interceptor class can't get access to private constants through late static bindings
  2. Error: Undefined class constant 'XML_PATH_CATEGORY_URL_SUFFIX' in /var/www/magento2/public_html/vendor/magento/module-catalog/ViewModel/Product/Breadcrumbs.php:74 Stack trace: #0

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 3, 2020

Hi @Cheeerd. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Ready for QA in Community Backlog Sep 3, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 3, 2020
@toxix
Copy link
Member

toxix commented Sep 7, 2020

@magento I am working on this

@toxix
Copy link
Member

toxix commented Sep 7, 2020

This bug is the same category than this here #28981 and resolved in this pullrequest: #28797

Already checked an analog solution locally and it works, will open a pullrequest with the fix.

@toxix toxix mentioned this issue Sep 7, 2020
Merged
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Sep 7, 2020
@toxix
Copy link
Member

toxix commented Sep 7, 2020 •
edited
Loading

@Cheeerd you might want to check if my change is fixing your issue. As I was running into the same issue while upgrading a magento system.

@ghost ghost added Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Sep 8, 2020
@mrtuvn mrtuvn mentioned this issue Sep 9, 2020
Closed
1 task
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Sep 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @Cheeerd. Thank you for your report.
The issue has been fixed in #29925 by @toxix in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 10, 2020
magento-engcom-team added a commit that referenced this issue Sep 10, 2020
@magento-engcom-team
ENGCOM-8157: Fix #29879 Breadcrump Undefined class constant 'XML_PATH…
e7f6599 
…_CATEGORY_URL_SUFFIX' #29925

 - Merge Pull Request #29925 from toxix/magento2:fix-29879-breadcrump-static-reference-error
 - Merged commits:
   1. 2d1d097
magento-engcom-team pushed a commit that referenced this issue Sep 10, 2020
@gabrieldagama
ENGCOM-8157: Fix #29879 Breadcrump Undefined class constant 'XML_PATH…
dc84979 
…_CATEGORY_URL_SUFFIX' #29925
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toxix toxix

Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #29879 Breadcrump Undefined class constant 'XML_PATH_CATEGORY_URL_SUFFIX' toxix/magento2
3 participants
@toxix @Cheeerd @magento-engcom-team