-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Component: CatalogSearchComponent: ReportsComponent: SalesComponent: TaxFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedGate 1 Failed. Automatic verification of issue format is failedPriority: P4No current plan to fix. Fixing can be deferred as a logical part of more important work.No current plan to fix. Fixing can be deferred as a logical part of more important work.Progress: doneSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.Affects aesthetics, professional look and feel, “quality” or “usability”.
Description
This issue is automatically created based on existing pull request: #30120: Cleaned up duplicate variable assignments in the same line
Description (*)
Re-apply changes from #28085
This is a simple cleanup of two assignments to the same variable occurring in the same line.
Created by using the following regex:
($.*) = \1 = (with space before to exclude things like self::$loader = $loader = new \Composer\Autoload\ClassLoader(); and with space after to make sure it's an assignment and not anything else like ===)
And replacing with:
$1 = (also with space before and after to keep the formatting right)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
none required
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Component: CatalogSearchComponent: ReportsComponent: SalesComponent: TaxFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedGate 1 Failed. Automatic verification of issue format is failedPriority: P4No current plan to fix. Fixing can be deferred as a logical part of more important work.No current plan to fix. Fixing can be deferred as a logical part of more important work.Progress: doneSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.Affects aesthetics, professional look and feel, “quality” or “usability”.
Type
Projects
Status
Done