GraphQL returns null address if optional telephone is set as empty string

[Magepim]

Preconditions (*)

1. Version 2.4.0 and 2.4-develop

Steps to reproduce (*)

1.Configure Magento address settings to have telephone number as optional.
2. Using GraphQL add a billing address to a quote using an empty string as the telephone value
3. Execute cart query via GraphQL. Billing address will return as 'null'

Expected result (*)

1. Billing address expected to return in GraphQL response with full address details shown

Actual result (*)

1. billing address returns as null.
2. This is caused because the telephone field in the CartAddressInput in the GraphQL schema is marked as non-nullable. Magento saved the telephone value as null in the quote address when it is passed an empty string. The address is then validated against the schema when the response is being prepared and fails the schema validation.

Additional info from Engcom

Steps to reproduce

1. From Admin, go to Stores - Configuration - Customer - Customer Configuration - Name and Address Options. Set Show Telephone to Optional
   
2. Using GraphQL mutation, add a product to Cart
3. Set Billing Address on cart using the following Mutation

mutation {
  setBillingAddressOnCart(
    input: {
      cart_id: "YOrpn8PaE1sNO88W4KTqGlMu1UB6Rpoh"
      billing_address: {
        address: {
          firstname: "Bob"
          lastname: "Roll"
          company: "Magento"
          street: [
            "Magento Pkwy"
            "Main Street"
          ]
          city: "Austin"
          region: "TX"
          postcode: "78758"
          telephone: ""        #<---- note that the telephone is an empty string. 
          country_code: "US"
          save_in_address_book: true
        }
        same_as_shipping: false
      }
    }
  ) {
    cart {
      billing_address {
        firstname
        lastname
        company
        street
        city
        region {
          code
          label
        }
        postcode
        telephone
        country {
          code
          label
        }
      }
    }
  }
}

4. Query Cart

query{
  cart(cart_id: "YOrpn8PaE1sNO88W4KTqGlMu1UB6Rpoh"){
    billing_address{
      city
      firstname
      lastname
      telephone
      region{
        code
      }
      street
    }
    items{
      id
      quantity
      product{
        name
      }
    }
  }
}

Actual Result
Cart query displayed Billing Adress as null

{
  "data": {
    "cart": {
      "billing_address": null,
      "items": [
        {
          "id": "1",
          "quantity": 3,
          "product": {
            "name": "Sproduct"
          }
        }
      ]
    }
  }
}

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• [X ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Magepim. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Magepim]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @Magepim. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @Magepim, here is your Magento Instance: https://5ae934474cc9d241fbacb4dd285bb850-2-4-develop.instances.magento-community.engineering
Admin access: https://5ae934474cc9d241fbacb4dd285bb850-2-4-develop.instances.magento-community.engineering/admin_0190
Login: 812ad144
Password: a85ce201d348

[Magepim]

@magento I am working on this

[m2-assistant]

Hi @Magepim! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[Magepim]

@magento add to contributors team

[m2-assistant]

Hi @Magepim! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

[Magepim]

@magento I am working on this

[ashish-viradiya]

@magento I am working on this.

[ashish-viradiya]

#dmcdindia2020

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

The issue is reproducible on the latest 2.4-develop. Additional info from Engcom is added to the description

[SaftaArtem]

@magento add to contributors team

[m2-assistant]

Hi @SaftaArtem! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

[SaftaArtem]

@magento I am working on this

[SaftaArtem]

@magento give me test instance

[magento-deployment-service]

Hi @SaftaArtem. Thank you for your request. Comments like @magento give me test instance are intended for instance deployments on Pull Requests. Please use comment like: @magento give me 2.4-develop instance to request an instance on an issue.

[SaftaArtem]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @SaftaArtem. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @SaftaArtem, here is your Magento Instance: https://5ae934474cc9d241fbacb4dd285bb850-2-4-develop.instances.magento-community.engineering
Admin access: https://5ae934474cc9d241fbacb4dd285bb850-2-4-develop.instances.magento-community.engineering/admin_aabd
Login: 72255d14
Password: 7836d347a6a2

[SaftaArtem]

@magento run all tests